Insert random delay up to two mins to help collisions that cause timeouts #1272
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event async BDN tests from trying to insert at the same time.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a random delay step in the CI workflow to reduce insert collisions that cause timeouts during concurrent test runs.
- Added a new step in the CI workflow that pauses execution for a random duration between 1 and 120 seconds.
- The random delay is implemented in PowerShell within the GitHub Actions YAML file.
|
|
||
| - name: Random pause between tasks so multiple inserts don't run at the same time | ||
| run: | | ||
| $delay = Get-Random -Minimum 1 -Maximum 121 |
There was a problem hiding this comment.
[nitpick] Consider making the maximum delay duration configurable (e.g., via an environment variable) to allow easier adjustments in different CI environments.
Suggested change
| $delay = Get-Random -Minimum 1 -Maximum 121 | |
| $maxDelay = $env:MAX_DELAY_DURATION | |
| $delay = Get-Random -Minimum 1 -Maximum [int]$maxDelay |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BDN tests are seeing a few insert collisions here and there when two test runs are trying to insert at the same time and it times out. This PR adds a task that randomly pauses up to 2 minutes so space out those that are started at the same time.