Skip Value Expiration Check When Scanning a Tombstoned Record#1612
Open
Skip Value Expiration Check When Scanning a Tombstoned Record#1612
Conversation
423b177 to
d6a7896
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes cluster slot migration failures when scans include tombstoned records (issue #1560) by avoiding expiration checks on tombstones, strengthening revivification pausing semantics, and updating/adding cluster migration tests to validate behavior.
Changes:
- Skip expiration validation in migration scan readers when the scanned record is a tombstone.
- Update
TsavoriteKV.PauseRevivification()to coordinate pause visibility via epoch bump + signaling. - Fix and extend cluster migration tests, including a new tombstone-focused migration test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/Garnet.test.cluster/ClusterMigrateTests.cs | Adjusts migrate test flow/expectations and adds a new tombstone migration test. |
| libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Tsavorite.cs | Implements epoch-coordinated revivification pause signaling and disposes the new event. |
| libs/cluster/Server/Migration/MigrateScanFunctions.cs | Skips expiration checks for tombstone records during scan to avoid null/value issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Tsavorite.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #1560. It also includes the following:
This is safe since expiration validation will occur when reading the actual value during TransmitKeys. If the key has expired at that point, it will be skipped.
Use GarnetClientSession to ensure the correct redirection messages are generated.