-
Notifications
You must be signed in to change notification settings - Fork 34
docs: Add Supported Platforms document #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: microsoft/main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is much needed.
| |----------|-------------|--------|-------| | ||
| | Linux | amd64 | ✅ Supported | Primary platform, Azure Linux 3.0+, Ubuntu 22.04+ | | ||
| | Linux | arm64 | ✅ Supported | Azure Linux 3.0+, Ubuntu 22.04+ | | ||
| | Linux | armv6l | ✅ Supported | Modern Linux distributions | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear what Modern Linux distributions actually exist on armv6l, and would we actually support them? (All of them?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one I'm not sure about, what was the original customer request for armv6l? Do we know what platform they required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forwarded you the original email thread.
|
@dagood updated PTAL |
| * `linux_arm64` | ||
| * `windows_amd64` | ||
| * `darwin_amd64` | ||
| * `darwin_arm64` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are still preview, right?
| @@ -0,0 +1,62 @@ | |||
| # Supported Platforms | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason to put this in the root dir rather than eng/doc?
|
|
||
| This document outlines the platform support matrix for different versions of the Microsoft build of Go. | ||
|
|
||
| "Support" in this context means that Microsoft actively tests these platforms and will accept bug reports for them. Platforms outside this scope are provided support on a best-effort basis with no guarantees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test in what sense? That the toolset works, or that it works at runtime? It seems like this doc is only be about runtime behavior (it lists Windows arm64, which we can target but we don't ship a prebuilt toolset for).
Do we really test Windows arm64 and Linux armv6l?
Does a listing on this page imply that there's a supported platform-provided crypto backend?
| ### Go 1.23 | ||
| - macOS (Darwin) platforms not available | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... they were available in 1.22? 😄
| ### Go 1.23 | |
| - macOS (Darwin) platforms not available |
| - **Minimum supported distributions**: | ||
| - Azure Linux 3.0 (recommended) | ||
| - Ubuntu 22.04 and later | ||
| - CBL-Mariner 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a duplicate of the table?
I'm not sure a table is necessary, if we want to provide more details with more platform-specific context anyway.
| * `linux_arm64` | ||
| * `windows_amd64` | ||
| * `darwin_amd64` | ||
| * `darwin_arm64` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in the same order as https://github.com/microsoft/go/blob/microsoft/main/eng/doc/Downloads.md IMO.
First draft, will need some thorough reviews