Skip to content

[0002] Specify the grammar formulations for attributes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

llvm-beanz
Copy link
Collaborator

This does not exhaustively express all the places C++ attributes are valid, but it should cover enough detail to be useful.

Fixes #63.

@llvm-beanz llvm-beanz requested review from bogner, tex3d and pow2clk June 26, 2023 15:14
Copy link
Collaborator

@bogner bogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some minor editing notes that you can take or leave as you please.

@llvm-beanz llvm-beanz added the Design Meeting Agenda item for the design meeting label Nov 12, 2024
@llvm-beanz llvm-beanz changed the title Specify the grammar formulations for attributes [0002] Specify the grammar formulations for attributes Feb 10, 2025
Copy link
Collaborator

@V-FEXrt V-FEXrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the markups, if I'm understanding the grammar's grammar correctly I think it has some details wrong

@llvm-beanz llvm-beanz force-pushed the cbieneman/case-sensitive-attrs branch from 8b194ea to 059b06f Compare February 17, 2025 18:51
llvm-beanz and others added 5 commits April 1, 2025 08:16
This does not exhaustively express all the places C++ attributes are
valid, but it should cover enough detail to be useful.

Fixes microsoft#63.
This updates the grammar specification to align with how C++ specifies
parsing grammar, and the language spec latex is included. I've also
added images containing the rendered grammar for ease of reading.
@llvm-beanz llvm-beanz force-pushed the cbieneman/case-sensitive-attrs branch from 5ba82c6 to d4b7fb1 Compare April 1, 2025 13:19
@llvm-beanz llvm-beanz merged commit cfd63fb into microsoft:main Apr 1, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this to Triaged in HLSL Triage Apr 1, 2025
@github-project-automation github-project-automation bot moved this from In Review to Accepted in HLSL Language Features Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Meeting Agenda item for the design meeting needs-triage
Projects
Status: Accepted
Status: Triaged
Development

Successfully merging this pull request may close these issues.

[0002] Specify attribute parsing grammar
4 participants