Merge config objects

[eedorenko]

No description provided.

[Copilot]

Pull Request Overview

This PR aims to merge config objects while upgrading the YAML library. Key changes include:

• Upgrading the YAML library version in scheduler/templater.go from v2 to v3.
• Changing the array merging logic in controllers/assignment_controller.go to iterate through new array values and merge maps with matching "name" keys.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
scheduler/templater.go	Upgraded YAML dependency to v3 for improved YAML processing
controllers/assignment_controller.go	Revised merge logic to merge matching map objects by "name" key

Files not reviewed (1)

• go.mod: Language not supported

[Copilot]

Pull Request Overview

This PR aims to merge configuration objects by updating dependency versions and refining the object merging logic. Key changes include:

• Upgrading the YAML library from v2 to v3 in scheduler/templater.go.
• Revising the merge algorithm in controllers/assignment_controller.go to handle merging of array elements based on their "name" key.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
scheduler/templater.go	Upgraded YAML library from v2 to v3, which may affect output formatting.
controllers/assignment_controller.go	Replaced simple array appending with a merge strategy for map elements by "name".

Files not reviewed (1)

• go.mod: Language not supported

Comments suppressed due to low confidence (1)

scheduler/templater.go:30

• Ensure the migration from yaml.v2 to yaml.v3 is fully validated against expected YAML output, as v3 may introduce changes in formatting or handling edge cases compared to v2.

"gopkg.in/yaml.v3"

[Copilot]

Pull Request Overview

This pull request updates the YAML library version in the templater and refines the merge logic for config arrays by merging map entries based on a matching "name" key.

• Update YAML import from v2 to v3 in scheduler/templater.go
• Replace simple array appending with an iterative merge approach in controllers/assignment_controller.go

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
scheduler/templater.go	Updated YAML library from v2 to v3
controllers/assignment_controller.go	Modified merge logic to iteratively merge array elements based on "name" keys

Files not reviewed (1)

• go.mod: Language not supported

Comments suppressed due to low confidence (1)

controllers/assignment_controller.go:406

• Since yaml.v3 may produce maps with string keys rather than interface{} keys, please verify that the type assertions and comparisons for the "name" key are robust against potential mismatches. Consider adding explicit type conversions (e.g., casting to string) before comparison.

if existingValueMap["name"] == valueMap["name"] {