Revert "ssh connection supports ipv6" #3754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 967e89e. No idea how this was merged, sorry. Any connection_info.address can be a domain name, not a resolved IP addr, at that point. We get a straight Traceback (most recent call Last): File "<...>\lisa-overlake\lisa\lisa\util\shell.py", line 89, in wait_tcp_port_ready result = tcp_socket.connect_ex((address, port)) socket.gaierror: [Errno 11001] getaddrinfo failed with that.
squirrelsc
reviewed
Apr 8, 2025
LiliDeng
approved these changes
Apr 9, 2025
LiliDeng
requested changes
Apr 9, 2025
Collaborator
LiliDeng
left a comment
LiliDeng
left a comment
There was a problem hiding this comment.
I will raise a fix today.
Contributor
Author
Thank you, looking forward to it. |
Collaborator
Fixed in #3759, let know whether you still encounter the issue, thanks! |
Contributor
Author
|
OK, your change makes things better. Closing this one, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 967e89e.
No idea how this was merged, sorry. Any connection_info.address can be a domain name, not a resolved IP addr, at that point.
We get a straight
with that.