build/fs: modernize file-system helpers#4933
Open
mohiuddin-khan-shiam wants to merge 2 commits intomicrosoft:mainfrom
Open
build/fs: modernize file-system helpers#4933mohiuddin-khan-shiam wants to merge 2 commits intomicrosoft:mainfrom
mohiuddin-khan-shiam wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Replaced custom recursive directory creation and deprecated `fs.rmdirSync` logic with the native APIs introduced in Node ≥10:
* [ensureDir](cci:1://file:///c:/Users/T2430514/Downloads/monaco-editor/build/fs.ts:12:0-21:1) now calls `fs.mkdirSync(dirname, { recursive: true })`
– creates full path atomically
– avoids race conditions and extra loops
* [removeDir](cci:1://file:///c:/Users/T2430514/Downloads/monaco-editor/build/fs.ts:44:0-79:1) now ends with `fs.rmSync(dirPath, { recursive: true, force: true })`
– officially supported replacement for `fs.rmdirSync`
– handles non-empty directories and future Node versions
This simplifies the code, removes deprecation warnings on Node 16+, and prevents build/packaging scripts from failing on newer runtimes.
Co-Authored-By: S. M. Mohiuddin Khan Shiam <[email protected]>
Replaced custom recursive directory creation and deprecated `fs.rmdirSync` logic with the native APIs introduced in Node ≥10:
* [ensureDir](cci:1://file:///c:/Users/T2430514/Downloads/monaco-editor/build/fs.ts:12:0-21:1) now calls `fs.mkdirSync(dirname, { recursive: true })`
– creates full path atomically
– avoids race conditions and extra loops
* [removeDir](cci:1://file:///c:/Users/T2430514/Downloads/monaco-editor/build/fs.ts:44:0-79:1) now ends with `fs.rmSync(dirPath, { recursive: true, force: true })`
– officially supported replacement for `fs.rmdirSync`
– handles non-empty directories and future Node versions
This simplifies the code, removes deprecation warnings on Node 16+, and prevents build/packaging scripts from failing on newer runtimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced custom recursive directory creation and deprecated
fs.rmdirSynclogic with the native APIs introduced in Node ≥10:ensureDir now calls
fs.mkdirSync(dirname, { recursive: true })– creates full path atomically
– avoids race conditions and extra loops
removeDir now ends with
fs.rmSync(dirPath, { recursive: true, force: true })– officially supported replacement for
fs.rmdirSync– handles non-empty directories and future Node versions
This simplifies the code, removes deprecation warnings on Node 16+, and prevents build/packaging scripts from failing on newer runtimes.