Skip to content

Comments

Added Inbuilt function to extract nested JSON#798

Merged
ianhelle merged 9 commits intomicrosoft:mainfrom
pioneerHitesh:UAL-logs
Oct 21, 2024
Merged

Added Inbuilt function to extract nested JSON#798
ianhelle merged 9 commits intomicrosoft:mainfrom
pioneerHitesh:UAL-logs

Conversation

@pioneerHitesh
Copy link
Contributor

@pioneerHitesh pioneerHitesh commented Sep 18, 2024

Added Inbuilt function to extract nested JSON especially for AuditData Column. Closes #589.

@pioneerHitesh
Copy link
Contributor Author

@ianhelle could you please review this?

@pioneerHitesh
Copy link
Contributor Author

@ianhelle may you review this please?

(this is due to an update to pylint, not the code in this PR)
@ianhelle
Copy link
Contributor

Looks good. I have approved and ran build checks.
Looks like you have a couple of minor issues from pylint and pydocstyle - I've highlighted these in the comments.
I've also pushed a fix in network_plot.py - unrelated to this PR. This was triggered by a new or updated check in pylint.

@pioneerHitesh
Copy link
Contributor Author

@ianhelle I have fixed the liniting issues except for errors caused by thebandit. May you please help me fixing the timeout issues which bandit is reporting?

@ianhelle ianhelle merged commit 11ca944 into microsoft:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inbuilt function to extract nested JSON in AuditData field in M365 UAL logs

2 participants