Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication module unit test #800

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Conversation

ianhelle
Copy link
Contributor

Adding more comprehensive unit tests for authentication modules
Minor fixes to azure_auth.py and azure_auth_core.py

Minor fixes to azure_auth.py and azure_auth_core.py
@ianhelle ianhelle self-assigned this Sep 19, 2024
Copy link
Collaborator

@FlorianBracq FlorianBracq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes applied for typing and kwargs.

The new tests are helping me understand better how authentication actually works, thanks for the addition!

- in ip_utils and azure_auth_core.py
Fixing some import mocking itemrs in docs/source/conf.py
check for no results before trying pd.concat in provider_base.py
Copy link
Collaborator

@FlorianBracq FlorianBracq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me!

@ianhelle ianhelle merged commit 4d715ad into main Sep 23, 2024
10 checks passed
@ianhelle ianhelle deleted the ianhelle/authn-unittests-2024-09-19 branch September 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants