Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller gcdump storage #1307

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Smaller gcdump storage #1307

wants to merge 3 commits into from

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Nov 6, 2020

  • Use shared storage for module names
  • Apply differential compression to m_nodes
  • Apply differential compression to m_nodeAddresses

@brianrob
Copy link
Member

brianrob commented Nov 7, 2020

Can you share a comparison on what sort of benefit you see with and without this?

@sharwell
Copy link
Member Author

sharwell commented Nov 7, 2020 •
edited
Loading

For a heap dump with 330M objects, this change reduced the storage from ~9GiB (which is greater than the 8GiB gcdump limit of my modified build) to 6.22GiB. This is a prerequisite to upcoming work that doubles the amount of data PerfView can load at once.

Base automatically changed from master to main February 2, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @brianrob