-
Notifications
You must be signed in to change notification settings - Fork 32
update pcstac to use stac-fastapi 5.0 and stac-fastapi-pgstac 4.0 #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pcfuncs/funclib/raster.py
Outdated
| @abstractmethod | ||
| def mask(self: T, geom: Dict[str, Any]) -> T: ... | ||
| def mask(self: T, geom: Dict[str, Any]) -> T: | ||
| ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format change unrelated to the PR goal
pcfuncs/funclib/tiles.py
Outdated
| @abstractmethod | ||
| async def get_mosaic(self, tiles: List[Tile]) -> T: ... | ||
| async def get_mosaic(self, tiles: List[Tile]) -> T: | ||
| ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format change unrelated to the PR goal
| and "collection=" not in str(request.url) | ||
| and '{"property":"collection"}' | ||
| not in orjson.dumps(search_request.filter).decode("utf-8") | ||
| not in orjson.dumps(search_request.filter_expr).decode("utf-8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed filter to filter_expr input attributes in GET endpoint methods
ref: https://github.com/stac-utils/stac-fastapi-pgstac/blob/main/CHANGES.md#400---2025-02-03
| description=API_DESCRIPTION, | ||
| extra_conformance_classes=extra_conformance_classes, | ||
| post_request_model=post_request_model, | ||
| pgstac_search_model=post_request_model, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed post_request_model attribute to pgstac_search_model in CoreCrudClient class
ref: https://github.com/stac-utils/stac-fastapi-pgstac/blob/main/CHANGES.md#400---2025-02-03
| conformance_classes=[ | ||
| FilterConformanceClasses.FILTER, | ||
| FilterConformanceClasses.ITEM_SEARCH_FILTER, | ||
| FilterConformanceClasses.SEARCH, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed filter.FilterConformanceClasses.ITEM_SEARCH_FILTER -> filter.FilterConformanceClasses.SEARCH
ref: renamed filter.FilterConformanceClasses.ITEM_SEARCH_FILTER -> filter.FilterConformanceClasses.SEARCH
| app.root_path, schema, tag=f"STAC API {STAC_API_VERSION}" | ||
| ) | ||
| app.openapi_schema = fixed_schema | ||
| return fixed_schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is maybe the biggest change with this PR that doesn't seem well tested in tests
a4cc457 to
1b76532
Compare
|
not sure what's going on and why stac-api-validator is failing. the error message is but locally when I run the service and change the /collections links I get the correct url 🤷 Using Stac-check also ✅ |
Description
This PR should fixe the pagination issue with new PgSTAC database. I choose not to update to stac-fastapi 6.0 and stac-fastapi-pgstac 6.0 to keep the change manageable.
Fixes #274
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Please delete options that are not relevant.