Remove special handling for getSelection() with Firefox from tests

[whimboo]

We got https://bugzilla.mozilla.org/show_bug.cgi?id=85686 in Firefox fixed for version 138 which is currently in Nightly. That means that we no longer need to special-case the handling for getSelection() with Firefox.

I assume this PR needs to wait with getting merged until Firefox 138 is going to be released?

[sefeng211]

It's Nightly only feature for now, I plan to give it some time before enabling it. So we should only remove the special-case handling after it's enabled in Release

[whimboo]

Oh, good point. Lets move this PR to draft for now.

[whimboo]

Enabling by default for all Firefox builds is covered by https://bugzilla.mozilla.org/show_bug.cgi?id=1954979.

[github-actions]

Test results for "tests 1"

4 failed
❌ [firefox-page] › tests/page/elementhandle-select-text.spec.ts:20:3 › should select textarea @firefox-ubuntu-22.04-node18
❌ [firefox-page] › tests/page/elementhandle-select-text.spec.ts:33:3 › should select input @firefox-ubuntu-22.04-node18
❌ [firefox-page] › tests/page/locator-misc-2.spec.ts:76:3 › should select textarea @firefox-ubuntu-22.04-node18
❌ [firefox-page] › tests/page/retarget.spec.ts:212:3 › input value retargeting @firefox-ubuntu-22.04-node18

4 flaky

⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:773:1 › should handle src=blob @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38780 passed, 808 skipped
✔️✔️✔️

Merge workflow run.

[yury-s]

@whimboo what is the status of this? The Firefox bug has been closed, do we just wait for the next FF roll?

FYI, I'm also enabling the tests in WebKit: #35498.

[whimboo]

@whimboo what is the status of this? The Firefox bug has been closed, do we just wait for the next FF roll?

The fix will be in Firefox 139 - where it will be enabled by default. It will ride the trains and will be released on May 27th. If you want to get rid of this code already for 138 which is on beta now, you could temporarily use the dom.selection.mimic_chrome_tostring.enabled preference and set it to true. It's release will be on April 29th.

But I think that this change can wait for the 139 release given that it was broken for such a long time.

[yury-s]

Ok, let's wait until it is released.

[whimboo]

I updated the PR to fix the actual merge conflicts in the tests. Do you already have an ETA for when your custom Firefox 139 will be available?

[yury-s]

Do you already have an ETA for when your custom Firefox 139 will be available?

We usually try to include current release of Firefox, so it we should roll 139 soon after it becomes stable. You can track our rolls in https://github.com/microsoft/playwright-browsers/blob/main/browser_patches/firefox/BUILD_NUMBER

[whimboo]

@yury-s can you please review? Thanks.

[yury-s]

The change looks good to me, let's rebase an make sure the tests pass.

[mxschmitt]

Thank you!

[github-actions]

Test results for "tests 1"

5 flaky

⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @chromium-ubuntu-22.04-node22
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-event-popup.spec.ts:28:3 › should work with window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39353 passed, 820 skipped
✔️✔️✔️

Merge workflow run.