Extended the type narrowing logic for the x == L type guard pattern…
#10164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so it supports the case where `x` is `LiteralString` and `L` is a string literal. This addresses #10162.
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:554:13 - error: Cannot access attribute "canon_bp" for class "Expr"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:554:13 - error: Cannot access attribute "canon_bp" for class "One"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:554:13 - error: Cannot access attribute "canon_bp" for class "Zero"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:554:13 - error: Cannot access attribute "canon_bp" for class "TensExpr"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Expr"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Zero"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "One"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "NegativeOne"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Integer"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Rational"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "NaN"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "ComplexInfinity"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Half"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Infinity"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "NegativeInfinity"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Float"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:558:15 - error: Cannot access attribute "canon_bp" for class "Number"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Expr"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "One"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "NegativeOne"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Zero"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Integer"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Rational"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "NaN"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "ComplexInfinity"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Half"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Infinity"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "NegativeInfinity"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:577:13 - error: Cannot access attribute "canon_bp" for class "Float"
- Attribute "canon_bp" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1602:36 - error: "__getitem__" method not defined on type "NegativeOne" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1602:36 - error: "__getitem__" method not defined on type "One" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1602:36 - error: "__getitem__" method not defined on type "TensExpr" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1608:43 - error: "__getitem__" method not defined on type "NegativeOne" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1608:43 - error: "__getitem__" method not defined on type "One" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1608:43 - error: "__getitem__" method not defined on type "TensExpr" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1663:41 - error: Operator "*" not supported for types "Literal[2]" and "Unknown | Any | Basic | ZeroArray | ArrayTensorProduct | ArrayContraction | Tuple | Indexed | ImmutableDenseNDimArray | NDimArray | None"
+ /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1663:41 - error: Operator "*" not supported for types "Literal[2]" and "Unknown | Any | Basic | Zero | ZeroArray | ArrayTensorProduct | ArrayContraction | Tuple | Indexed | ImmutableDenseNDimArray | NDimArray | None"
- Attribute "data" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1694:44 - error: Cannot access attribute "data" for class "NegativeOne"
- Attribute "data" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1694:44 - error: Cannot access attribute "data" for class "One"
- Attribute "data" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1694:44 - error: Cannot access attribute "data" for class "TensExpr"
- /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1697:17 - error: Operator "-" not supported for type "Unknown | Any | Basic | ZeroArray | ArrayTensorProduct | ArrayContraction | Tuple | Indexed | ImmutableDenseNDimArray | NDimArray" (reportOperatorIssue)
+ /tmp/mypy_primer/projects/sympy/sympy/tensor/tests/test_tensor.py:1697:17 - error: Operator "-" not supported for type "Unknown | Any | Basic | Zero | ZeroArray | ArrayTensorProduct | ArrayContraction | Tuple | Indexed | ImmutableDenseNDimArray | NDimArray" (reportOperatorIssue)
+ /tmp/mypy_primer/projects/sympy/sympy/utilities/codegen.py:608:47 - error: "__getitem__" method not defined on type "set[Unknown]" (reportIndexIssue)
- /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_lambdify.py:2032:45 - error: Argument of type "(e: Unknown) -> (Unknown | tuple[list[tuple[Unknown, Unknown]], list[Unknown]])" cannot be assigned to parameter "cse" of type "bool" in function "lambdify"
+ /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_lambdify.py:2032:45 - error: Argument of type "(e: Unknown) -> (tuple[Unknown, str] | tuple[Unknown | list[tuple[Unknown, Unknown]], list[Unknown] | set[Unknown] | tuple[Unknown, ...]] | tuple[Unknown | list[tuple[Unknown, Unknown]], dict[Unknown, Unknown]] | tuple[Unknown | list[tuple[Unknown, Unknown]], Unknown] | tuple[list[Unknown], Unknown] | tuple[list[tuple[Unknown, Unknown]], list[Unknown]] | Unknown)" cannot be assigned to parameter "cse" of type "bool" in function "lambdify"
- /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1803:43 - error: Cannot access attribute "simplify" for class "tuple[Unknown | Basic | Add | Expr | Mul | Dict, bool]"
... (truncated 17 lines) ...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so it supports the case where
xisLiteralStringandLis a string literal. This addresses #10162.