Discard TypeEvaluator if cancellation leaves partially-constructed function type in cache
#8118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
erictraut
approved these changes
Jun 11, 2024
|
You hit the same MacOS test failure that I've been seeing sporadically. It tends to go away if you run the test again, but that's unnerving. I've never been able to repro it locally on my Mac. I've reviewed the test code to try to determine potential causes, and I'm not able to find the problem. It could be related to a timeout in the test framework. I somewhat suspect that it's related to my other recent change that I asked you to code review. This error started at about the same time. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
@debonte, is the PR ready from your standpoint? If so, let's merge it so we can get it into today's pyright release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the function equivalent of the class cancellation fix in #5786.
If
getTypeOfFunctionDecoratedorgetTypeOfLambdaWithExpectedTypeare cancelled before they complete, which would leave a partially evaluated function type in the type cache, we now setisTypeCacheInvalidtotrueon theOperationCanceledException. This will causeProgram._runEvaluatorWithCancellationTokento discard theTypeEvaluatorand create a new instance.I believe this will address microsoft/pylance-release#4295.