Setting up initial language service configuration. #2355

idavis · 2025-05-01T00:09:07Z

No description provided.

vscode/src/webviewPanel.ts

wasm/src/lib.rs

vscode/src/common.ts

vscode/src/debugger/activate.ts

minestarks

Random set of comments for what I've looked at so far

compiler/qsc_project/src/project.rs

compiler/qsc_project/src/tests.rs

compiler/qsc_qasm/src/compiler.rs

compiler/qsc_qasm/src/io.rs

playground/src/editor.tsx

minestarks

Finished reviewing the language_service rust crate - dropping this batch of comments before moving on

language_service/src/state.rs

language_service/src/qasm.rs

language_service/src/completion.rs

language_service/src/qasm.rs

compiler/qsc_project/src/project.rs

language_service/src/completion/text_edits.rs

language_service/src/compilation.rs

minestarks

finished language_service crate, wasm and npm layers - big thing for me to look at next is vs code

language_service/src/compilation.rs

npm/qsharp/src/compiler/compiler.ts

Co-authored-by: Mine Starks <[email protected]>

vscode/package.json

vscode/src/config.ts

vscode/src/circuit.ts

vscode/src/statusbar.ts

vscode/src/utils.ts

…nfig files

vscode/package.json

idavis self-assigned this May 1, 2025

github-advanced-security bot found potential problems May 1, 2025

View reviewed changes

vscode/src/webviewPanel.ts Dismissed Show dismissed Hide dismissed

vscode/src/webviewPanel.ts Dismissed Show dismissed Hide dismissed

wasm/src/lib.rs Dismissed Show dismissed Hide dismissed

billti reviewed May 2, 2025

View reviewed changes

vscode/src/common.ts Outdated Show resolved Hide resolved

billti reviewed May 2, 2025

View reviewed changes

vscode/src/debugger/activate.ts Outdated Show resolved Hide resolved

minestarks reviewed May 2, 2025

View reviewed changes

idavis marked this pull request as ready for review May 6, 2025 17:24

idavis requested review from swernli, DmitryVasilevsky and ScottCarda-MS as code owners May 6, 2025 17:24

idavis requested review from minestarks and billti May 6, 2025 18:34

idavis force-pushed the iadavis/ls-updates branch from b6a1e6f to b1a5c2e Compare May 6, 2025 23:39

billti reviewed May 7, 2025

View reviewed changes

playground/src/editor.tsx Outdated Show resolved Hide resolved

minestarks reviewed May 7, 2025

View reviewed changes

idavis requested review from billti and minestarks May 8, 2025 19:22

minestarks reviewed May 8, 2025

View reviewed changes

language_service/src/compilation.rs Outdated Show resolved Hide resolved

npm/qsharp/src/compiler/compiler.ts Show resolved Hide resolved

idavis and others added 13 commits May 12, 2025 07:57

Setting up initial language service configuration.

5621308

Cleanup

faf5667

Add lenses

80557d0

Cleanup

ba8ea53

Fixing tests, refactoring.

876699a

Feedback and test updates.

ea0c801

Integration test type fixes

45bbdec

Update compiler/qsc_project/src/project.rs

e6a9526

Co-authored-by: Mine Starks <[email protected]>

Feedback

da40509

Trying to clean up API

c8c3f06

More API cleanup

b5ea333

Feedback and cleanup

e21ba26

Adding debugger tests

5f98310

idavis added 16 commits May 12, 2025 07:57

Refactoring completions

8dd9877

Ensure project is closed correctly when final document is closed.

fe6b497

Renaming

60e8902

Change silent overload to unreachable.

454f15e

Clean up project load naming

14df05f

Cleanup unused args.

89ed598

Add openqasm completion tests

28a2908

Don't leak PackageGraphSources into non Q# projects in Rust layer

fde8081

Remove editor changes. Defaults will do what is needed.

a4180a2

Clean up error and finish message

3d45639

Remove underscore kw completion

6e7c8a1

Removing incorrect deps

2bddad6

Move project loading into qsc_project

335b9ff

Refactoring TS integration

3977c6d

Only enable debugging when debugging

3fac71e

Update status bar text for QIR profile

9fd715e

idavis force-pushed the iadavis/ls-updates branch from 6cf6e7d to 9fd715e Compare May 12, 2025 16:06

minestarks approved these changes May 12, 2025

View reviewed changes

vscode/package.json Outdated Show resolved Hide resolved

vscode/src/config.ts Outdated Show resolved Hide resolved

vscode/src/circuit.ts Outdated Show resolved Hide resolved

vscode/src/statusbar.ts Outdated Show resolved Hide resolved

vscode/src/utils.ts Show resolved Hide resolved

idavis added 5 commits May 12, 2025 10:05

Feedback

8657bf3

Feedback

09378fe

Use default file icon

063c91f

Use the qsharp debugger name to avoid breaking users with existing co…

d174660

…nfig files

Register openqasm so that F5 works

c043563

billti reviewed May 12, 2025

View reviewed changes

vscode/package.json Outdated Show resolved Hide resolved

Updating package desc

292acb1

idavis enabled auto-merge May 12, 2025 19:24

idavis added this pull request to the merge queue May 12, 2025

Merged via the queue into main with commit c8afce2 May 12, 2025
18 checks passed

idavis deleted the iadavis/ls-updates branch May 12, 2025 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting up initial language service configuration. #2355

Setting up initial language service configuration. #2355

idavis commented May 1, 2025

minestarks left a comment

minestarks left a comment

minestarks left a comment

Setting up initial language service configuration. #2355

Setting up initial language service configuration. #2355

Conversation

idavis commented May 1, 2025

minestarks left a comment

Choose a reason for hiding this comment

minestarks left a comment

Choose a reason for hiding this comment

minestarks left a comment

Choose a reason for hiding this comment