-
Notifications
You must be signed in to change notification settings - Fork 127
Update branding to Microsoft Quantum Development Kit #2438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.gitignore
Outdated
@@ -20,3 +20,4 @@ __pycache__/ | |||
.pytest_cache/ | |||
.idea/ | |||
*.so | |||
scratch/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sneaking this is as a convenience (I often keep working projects or notebooks in this location so it avoid the git diff clutter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this, but have you considered adding a personal .gitignore file with git config --local core.excludesFile .gitignore-local
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a readme file in this folder, check it in and then add this git ignore. I have a need for this as well, but I often use samples folder instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that make our already busy top-level folder structure even more busy?
For my part, I don't think this is change makes sense to do here, but if others are fine with it then it's not the worst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that make our already busy top-level folder structure even more busy?
But nothing is going to get checked in there - that's the point of it being in the .gitignore. I just like to have a 'working folder' for experiements when I have the qsharp workspace open but not have the git change list cluttered with things I don't want to actually check-in (also avoids accidentally checking them in). (I often put them under samples
also as Dmitry alluded to, so that's an option).
I can take it out of here and discuss separately. It's unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the top level being busier was in response to Dmitry's suggestion to check the folder in with a readme and then add it to the gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought my personal gitinore suggestion was pretty good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚲 🏚️ 🤣
.gitignore
Outdated
@@ -20,3 +20,4 @@ __pycache__/ | |||
.pytest_cache/ | |||
.idea/ | |||
*.so | |||
scratch/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this, but have you considered adding a personal .gitignore file with git config --local core.excludesFile .gitignore-local
?
vscode/README-DEV.md
Outdated
of upcoming features. | ||
|
||
To install the tested version of this extension, visit <https://marketplace.visualstudio.com/items?itemName=quantum.qsharp-lang-vscode>. | ||
The README for the stable build contains details on features and usage. | ||
|
||
For more information about the Modern QDK and Azure Quantum, visit [https://aka.ms/AQ/Documentation](https://aka.ms/AQ/Documentation). | ||
For more information about the Modern QDK and Microsoft Quantum, visit [https://aka.ms/qdk](https://aka.ms/qdk). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we feel about the "Modern QDK" now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - we hate it! Will delete and look for other occurence :-)
}, | ||
{ | ||
"command": "qsharp-vscode.createNotebook", | ||
"category": "QDK", | ||
"title": "Create an Azure Quantum notebook" | ||
"title": "Create a Microsoft Quantum notebook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one creates a sample that actually uses Azure Quantum, so the name may actually be appropriate?
@@ -31,13 +31,13 @@ | |||
"walkthroughs": [ | |||
{ | |||
"id": "qsharp-vscode.welcome", | |||
"title": "The Azure Quantum Development Kit", | |||
"description": "Getting started with the Azure Quantum Development Kit in VS Code", | |||
"title": "The Microsoft Quantum Development Kit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "Microsoft Quantum Development Kit"? (or are we going for something like "The Batman" 😜)
@@ -11,7 +11,7 @@ export const notebookTemplate: vscode.NotebookData = { | |||
{ | |||
kind: vscode.NotebookCellKind.Markup, | |||
languageId: "markdown", | |||
value: `## Azure Quantum Q# notebook | |||
value: `## Microsoft Quantum Q# notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above - the notebook content does include Azure Quantum so the name may be fine?
No description provided.