feat(conntrack-metrics): legacy control plane basic mode #1253
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
requested changes
Jan 21, 2025
SRodi
force-pushed
the
feat/ct-metrics-legacy-cp
branch
from
3fa4154 to
bcc9773
Compare
MikeZappa87
reviewed
Jan 21, 2025
| @@ -43,6 +43,13 @@ const ( | |||
| // Control plane metrics | |||
| pluginManagerFailedToReconcileCounterDescription = "Number of times the plugin manager failed to reconcile the plugins" | |||
| lostEventsCounterDescription = "Number of events lost in control plane" | |||
|
|
|||
| // Conntrack metrics | |||
| ConntrackPacketForwardDescription = "Number of forward packets" | |||
There was a problem hiding this comment.
I think we should use ‘forward’ since in this context we refer to ‘direction’ more than ‘action’. We also want to be consistent with the actual metrics implementation in BPF, which uses 'forward' and 'reply'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation of conntrack metrics for the legacy control plane in basic mode. The aggregation is at the node level, which makes the metric bounded.
Metrics:
Related Issue
fixes #1190
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Bytes reply
Total connections metric
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.