[rush] Add support for .env files. #5155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
dmichon-msft
approved these changes
Mar 24, 2025
octogonz
reviewed
Mar 28, 2025
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
Does rushx support this feature as well?
octogonz
reviewed
Mar 28, 2025
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "changes": [ | |||
| { | |||
There was a problem hiding this comment.
Is <repo root>/.env intended to be committed to Git? Or is it for the user only? We should document the intended usage.
octogonz
reviewed
Mar 28, 2025
| "changes": [ | ||
| { | ||
| "packageName": "@microsoft/rush", | ||
| "comment": "Add support for setting environment variables via `<repo-root>/.env` and `~/.rush-user/.env` files.", |
There was a problem hiding this comment.
Impacted documentation
This should be documented.
@iclanton could you add a note to the top of https://rushjs.io/pages/configs/environment_vars/ ? That is probably the most discoverable place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for loading env vars via
<repo root>/.envand~/.rush-user/.envfiles.How it was tested
Tested by setting the new variable introduced in #5154 in a
.envfile.Impacted documentation
This should be documented.