This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
avoid unchecked casts in AbstractGremlinResultReader#readProperty
#256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small improvement of the
readProperty
method: I replaced the unchecked cast with some more robust ones that don't rely on a specific implementation ofjava.util.Map
. This allows me to use this library with Amazon Neptune and theSerializers.GRAPHSON_V1D0
(org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0
).The recommended
Serializers.GRAPHSON
(org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV1d0
) did not work in my project, because it produced the same data structure as handled in #243.Todos
Steps to Test
Serializers.GRAPHSON_V1D0
Vertex
class and respectiveRepository
repository.save
orrepository.findAll