-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - nvbandwidth benchmark need to handle N/A value #675
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 3459eac.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
- Coverage 85.61% 85.45% -0.16%
==========================================
Files 99 99
Lines 7165 7210 +45
==========================================
+ Hits 6134 6161 +27
- Misses 1031 1049 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@polarG , do we also handle when we run few tests that are not valid for the underlying system. Such tests results in output as "waived".
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add test cases for the "N/A" and "Waived" cases
Good point! I will try to catch this in the code. |
Its better to show the waived test in the report in line with how other failed benchmarks are treated. |
Looks good to me. One more question for docs: Any documents need to be updated to align this change? |
Description