Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pane context menu #18126

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
+184 −17
Open

Updated pane context menu #18126

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0ac796f
added split up/down/left/right context menus
dmitrykok Oct 29, 2024
d920a70
added build win x64 release script
dmitrykok Oct 29, 2024
7e41e64
moved split up/down/left/right context menus as submenu
dmitrykok Oct 30, 2024
58cbe3a
added to split with profile to up/down/left/right context menu, added…
dmitrykok Oct 30, 2024
6e2529b
fix startup directory for split with profile to up/down/left/right co…
dmitrykok Oct 30, 2024
c953b44
Merge branch 'microsoft:main' into main
dmitrykok Oct 30, 2024
ef25c63
update win x64 release build script
dmitrykok Oct 30, 2024
f900ea5
added translations for available languages
dmitrykok Oct 30, 2024
a57aff8
Update settings.json
dmitrykok Oct 30, 2024
ae838ec
Update settings.json
dmitrykok Oct 30, 2024
ab01742
removed newly added file
dmitrykok Oct 30, 2024
4ab861c
put back comments removed by mistake in TerminalPage.cpp, revert the …
dmitrykok Oct 30, 2024
409783a
revert .vscode/settings.json
dmitrykok Oct 30, 2024
e21c0b7
fixed Resources.resw SwapPaneText resource
dmitrykok Nov 1, 2024
12aad74
Update TerminalPage.cpp
dmitrykok Nov 1, 2024
f682222
the split pane entries exists twice on the second level, add a 'dupli…
dmitrykok Nov 2, 2024
3bcaa51
add visible with a separation line between the 'duplicate' entry and …
dmitrykok Nov 7, 2024
2c303d0
Update TerminalPage.cpp
dmitrykok Nov 7, 2024
0cabf20
fixed pane context menu separators
dmitrykok Nov 7, 2024
e6f0d6a
Update TerminalPage.cpp
dmitrykok Nov 7, 2024
526e0a9
fixed pane context menu separators, and formatting
dmitrykok Nov 7, 2024
52dbc03
Merge branch 'main' of github.com:dmitrykok/terminal
dmitrykok Nov 7, 2024
82aa44a
fixed formatting
dmitrykok Nov 7, 2024
bf1e135
update swap menu, show only available options
dmitrykok Nov 8, 2024
1d5a220
add find to context menu even if there is no selection
dmitrykok Nov 8, 2024
54c9c60
Update src/cascadia/TerminalApp/Resources/en-US/Resources.resw
dmitrykok Dec 11, 2024
9a936f4
cache the value of focusedProfile.Name() and focusedProfile.Icon(), c…
dmitrykok Dec 11, 2024
8cf4ad6
No need to manually override the value from the profile, with the val…
dmitrykok Dec 11, 2024
ea1dc48
pane split with profiles reworked, pane split context menu has submen…
dmitrykok Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add visible with a separation line between the 'duplicate' entry and … 
…the other ones, changed from 'Duplicate pane' to 'Duplicate <profile_name>'
@dmitrykok
dmitrykok committed Nov 7, 2024
commit 3bcaa51a69c9a40e3e543d74afe9b262650ba7a9
2 changes: 1 addition & 1 deletion src/cascadia/TerminalApp/Resources/en-US/Resources.resw
View file
Original file line number Diff line number Diff line change
@@ -224,7 +224,7 @@
<value>Split Pane Left</value>
</data>
<data name="SplitPaneDuplicateText" xml:space="preserve">
<value>Duplicate pane</value>
<value>Duplicate</value>
</data>
<data name="SwapPaneText" xml:space="preserve">
<value>Swap pane</value>
15 changes: 11 additions & 4 deletions src/cascadia/TerminalApp/TerminalPage.cpp
View file
Original file line number Diff line number Diff line change
@@ -5086,10 +5086,17 @@ namespace winrt::TerminalApp::implementation

const auto focusedProfile = _GetFocusedTabImpl()->GetFocusedProfile();

makeItem(RS_(L"SplitPaneDuplicateText"), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Down, .5, nullptr } }, splitPaneDownMenu);
makeItem(RS_(L"SplitPaneDuplicateText"), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Up, .5, nullptr } }, splitPaneUpMenu);
makeItem(RS_(L"SplitPaneDuplicateText"), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Right, .5, nullptr } }, splitPaneRightMenu);
makeItem(RS_(L"SplitPaneDuplicateText"), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Left, .5, nullptr } }, splitPaneLeftMenu);
makeItem(RS_(L"SplitPaneDuplicateText") + L" " + focusedProfile.Name(), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Down, .5, nullptr } }, splitPaneDownMenu);
makeItem(RS_(L"SplitPaneDuplicateText") + L" " + focusedProfile.Name(), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Up, .5, nullptr } }, splitPaneUpMenu);
makeItem(RS_(L"SplitPaneDuplicateText") + L" " + focusedProfile.Name(), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Right, .5, nullptr } }, splitPaneRightMenu);
makeItem(RS_(L"SplitPaneDuplicateText") + L" " + focusedProfile.Name(), focusedProfile.Icon(), ActionAndArgs{ ShortcutAction::SplitPane, SplitPaneArgs{ SplitType::Duplicate, SplitDirection::Left, .5, nullptr } }, splitPaneLeftMenu);

// add menu separator
auto separatorItem = AppBarSeparator{};
splitPaneDownMenu.SecondaryCommands().Append(separatorItem);
splitPaneUpMenu.SecondaryCommands().Append(separatorItem);
splitPaneRightMenu.SecondaryCommands().Append(separatorItem);
splitPaneLeftMenu.SecondaryCommands().Append(separatorItem);

for (auto profileIndex = 0; profileIndex < activeProfileCount; profileIndex++)
{

Unchanged files with check annotations Beta

View file
.github/actions/spelling/expect/alphabet.txt
BBBBCCCCC
BBGGRR
efg
EFG

Check warning on line 17 in .github/actions/spelling/expect/alphabet.txt

GitHub Actions / Spell checking 

`EFG` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
efgh
EFGh

Check warning on line 19 in .github/actions/spelling/expect/alphabet.txt

GitHub Actions / Spell checking 

`EFGh` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
KLMNOQQQQQQQQQQ
QQQQQQQQQQABCDEFGHIJ
QQQQQQQQQQABCDEFGHIJKLMNOPQRS
View file
.github/actions/spelling/expect/expect.txt
DECPS
DECRARA
decrc
DECRC

Check warning on line 424 in .github/actions/spelling/expect/expect.txt

GitHub Actions / Spell checking 

`DECRC` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
DECREQTPARM
DECRLM
DECRPM
DECSACE
DECSASD
decsc
DECSC

Check warning on line 440 in .github/actions/spelling/expect/expect.txt

GitHub Actions / Spell checking 

`DECSC` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
DECSCA
DECSCNM
DECSCPP
Hostx
HPA
hpcon
HPCON

Check warning on line 802 in .github/actions/spelling/expect/expect.txt

GitHub Actions / Spell checking 

`HPCON` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
hpen
HPR
HProvider
RIGHTBUTTON
riid
ris
RIS

Check warning on line 1545 in .github/actions/spelling/expect/expect.txt

GitHub Actions / Spell checking 

`RIS` is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
roadmap
robomac
rodata