Closed
Conversation
Closed
Member
Author
|
Looks like this is not very far from being able to build, I would like to see comment on every NoWarn that was added to say why that is necessary, so we don't end up adding noWarn automatically every time the trimmer complains, defeating the purpose of the trimmer. |
Contributor
|
The purpose of this change was to help ensure minimal dependencies are shipped with MSTest. Do you plan to re-start this work from scratch? |
Member
Author
|
I will try to revisit it eventually, but it did not get much priority, and had no activity for a month (from me), and the exclusions need to be described. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing #5009