Skip to content

Fix MTP timeout parsing to use invariant culture instead of current culture #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 9 commits into from
Jun 10, 2025

Apply suggestions from code review

ea8f52a
Select commit
Loading
Failed to load commit list.
Merged

Fix MTP timeout parsing to use invariant culture instead of current culture #5705

Apply suggestions from code review
ea8f52a
Select commit
Loading
Failed to load commit list.
Azure Pipelines / microsoft.testfx (Build Windows Debug) failed Jun 10, 2025 in 9m 57s

Build Windows Debug failed

38 errors / 1 warnings

Annotations

Check failure on line 9 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Debug)

Build log #L9 

Publishing build artifacts failed with an error: Not found PathtoPublish: D:\a\_work\1\s\artifacts\TestResults\Debug

Check failure on line 240 in test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Debug)

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs#L240 

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs(240,1): error IDE0055: (NETCORE_ENGINEERING_TELEMETRY=Build) Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 245 in test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Debug)

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs#L245 

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs(245,1): error IDE0055: (NETCORE_ENGINEERING_TELEMETRY=Build) Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 249 in test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Debug)

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs#L249 

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs(249,1): error IDE0055: (NETCORE_ENGINEERING_TELEMETRY=Build) Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 220 in test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Windows Debug)

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs#L220 

test\UnitTests\Microsoft.Testing.Platform.UnitTests\CommandLine\PlatformCommandLineProviderTests.cs(220,21): error SA1025: (NETCORE_ENGINEERING_TELEMETRY=Build) Code should not contain multiple whitespace characters in a row (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1025.md)
View more details on Azure Pipelines