Adds the ability to register additional tokens via the @injectable decorator #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/tests/global-container.test.ts:326
- [nitpick] Consider renaming this test to distinguish it from the similar test starting at line 297; more descriptive names (e.g. indicating single vs. multiple token registrations) would improve clarity.
test("resolves all dependencies that provided additional tokens in the @injectable() decorator", () => {
Xapphire13
approved these changes
Apr 4, 2025
|
LGTM! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve:
#115
Passing a simple argument to
@injectable(), would allow the additional registrations of tokens for this current class. Allowing someone to tag their interfaces directly from the decorator and having them be resolved right away.@Xapphire13 Any thoughts?