fix(2426): goToDefinition for pattern ambient module no longer goes to implementation

[a-tarasyuk]

Fixes #2426

[DanielRosenwasser]

To minimize some of the diffs, can you do something like this?

l.converters.ToLSPRange(reference.file, reference.file.Loc)

(not sure if file might be nil though)

[a-tarasyuk]

@DanielRosenwasser thanks for the feedback. The file can be nil., even if it exists, this case is handled using a range with zero positions

https://github.com/microsoft/TypeScript/blob/f3770c9b89ba7969b163c5cea7805d5df23b2086/src/services/goToDefinition.ts#L123-L127

https://github.com/microsoft/TypeScript/blob/f3770c9b89ba7969b163c5cea7805d5df23b2086/src/services/goToDefinition.ts#L764-L774

if the file is used for the range, the selection will look like this

-// [||] export class Foo {}
+// [| export class Foo {}|]

Several differences in this PR are due to handling whitespace at the start of the file, for example

https://github.com/microsoft/typescript-go/pull/2429/files#diff-f36f4a55771065e64894e0d32a5c744439364e2a7804d6267af778e0d4ac09ddR3

https://github.com/microsoft/TypeScript/blob/f3770c9b89ba7969b163c5cea7805d5df23b2086/tests/cases/fourslash/goToDefinitionExternalModuleName.ts#L8

https://github.com/microsoft/TypeScript/blob/main/tests/baselines/reference/goToDefinitionExternalModuleName.baseline.jsonc#L3

Before

// [||]export class Foo {}

After

//[||] export class Foo {}

[DanielRosenwasser]

Several differences in this PR are due to handling whitespace at the start of the file, for example

In that case, createLspRangeFromNode or createLspRangeFromRange should take care of those differences.

[a-tarasyuk]

These diffs are related to missing chompLeadingSpace from the test parser. I’m not sure whether this behavior should be preserved.

[a-tarasyuk]

There are a couple of failing formatting tests, but they’re all in gen folder, which shouldn’t be modified directly. We probably need to regenerate the tests for these cases. For example, Strada behaviour for some of them,

this test has 4 spaces after ///
https://github.com/microsoft/TypeScript/blob/f3770c9b89ba7969b163c5cea7805d5df23b2086/tests/cases/fourslash/semicolonFormattingInsideAStringLiteral.ts#L3

but the behavior is validated with 3 spaces
https://github.com/microsoft/TypeScript/blob/f3770c9b89ba7969b163c5cea7805d5df23b2086/tests/cases/fourslash/semicolonFormattingInsideAStringLiteral.ts#L9

Anyway, the remaining question is whether we should proceed with or without the chompLeadingSpace helper.