Fix nil pointer dereference in import statement completions #2589
+58
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language server panics when requesting completions after typing keywords in import statements (e.g.,
import super,import this).Root Cause
ImportDeclaration.ImportClauseis optional in the AST, butgetImportStatementCompletionInfounconditionally callsIsTypeOnly()on it:This occurs when parsing incomplete import statements like
import <keyword>, where no ImportClause is created.Changes
import superandimport thisscenariosOriginal prompt
This section details on the original issue you should resolve
<issue_title>textDocument/completion runtime error: invalid memory address or nil pointer dereference</issue_title>
<issue_description>## Stack trace
Steps to reproduce
I was typing right here at the top. Seems pretty consistent to reproduce unlike other crashes I've experienced. Crashes right when I type the
rinsuper