Fix crash when completing after import preceded by JSDoc #2591
+34
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language service panics when requesting completions after an
importkeyword preceded by JSDoc comments:Root Cause
getSingleLineReplacementSpanForImportCompletionNodeusesnode.Pos()to check if the import spans multiple lines. When JSDoc precedes the import,node.Pos()includes the comment range, incorrectly indicating a multiline span and triggering the panic path.Changes
internal/ls/completions.go: Usescanner.GetTokenPosOfNode(node, sourceFile, false)instead ofnode.Pos()to exclude JSDoc/trivia when checking line spaninternal/fourslash/tests/manual/completionAfterImportWithJSDoc_test.go: Add regression testOriginal prompt
importwhen statement is preceded by JSDoc #2590✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.