Annotate all CompilerOptions fields with omitzero #639
+195
−8,975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Mar 17, 2025
|
Yes, though that all is thankfully before this display layer, and this is all a very quick hack for printing out configs anyhow... |
|
FWIW, it’s not just for display in my API branch; it gets sent to JS through that marshalling too. |
|
Oh, eek. Okay. Though the bits should actually come out to be the same, at least if one goes from Go to Go, but obviously omitting them on the Go side means they will be undefined on the JS side... |
|
Which is more than likely how they came in on the JSON side, which is why this whole thing is sketchy 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes baselines a lot cleaner.