[http-client-csharp]: Fix explode not being properly set for operation params #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check API changes are not detected in this pull request. |
jorgerangel-msft
force-pushed
the
fix-param-explode
branch
from
06693ea to
d668b75
Compare
jorgerangel-msft
force-pushed
the
fix-param-explode
branch
from
d668b75 to
075c152
Compare
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
In general, our definition of the parameter is quite cumbersome - all the parameters are sharing the same InputParameter model.
We should follow the definition of TCGC (they have discriminated models for each type of parameters) - @m_nash had the vision that our emitter should just redirect the data from TCGC therefore aligning their models on our side should be the first step.
But changing it is extremely complicated and we do not have to do it in this PR.
If you have further questions on how explode works, I think you could offline chat with @tadelesh
…-param-explode
…-param-explode
…-param-explode
…-param-explode
jorgerangel-msft
requested review from
m-nash and
JoshLove-msft
as code owners
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Jan 13, 2025
…-param-explode
…-param-explode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
explodeflag for a operation parameter was not being properly set when uri templates were specified. This is fixed now by passing through the value ofexplodefrom TCGC.There are several follow ups that are still needed to fully support URI templates and path expansion.
fixes: #5134
regen preview for autorest: Azure/azure-sdk-for-net#47775