Fix curl creating download dir in 750 mode (#1440)

moritz-h · web-flow · commit 6e77d57a1e57 · 2025-03-21T21:49:47.000Z
diff --git a/src/vcpkg/base/downloads.cpp b/src/vcpkg/base/downloads.cpp
@@ -1168,6 +1168,10 @@ namespace vcpkg
             }
         }
 #endif
+        // Create directory in advance, otherwise curl will create it in 750 mode on unix style file systems.
+        const auto dir = download_path_part_path.parent_path();
+        fs.create_directories(dir, VCPKG_LINE_INFO);
+
         auto cmd = Command{"curl"}
                        .string_arg("--fail")
                        .string_arg("--retry")

Original file line number	Diff line number	Diff line change
`@@ -1168,6 +1168,10 @@ namespace vcpkg`
`1168`	`1168`	`}`
`1169`	`1169`	`}`
`1170`	`1170`	`#endif`
	`1171`	`+ // Create directory in advance, otherwise curl will create it in 750 mode on unix style file systems.`
	`1172`	`+ const auto dir = download_path_part_path.parent_path();`
	`1173`	`+ fs.create_directories(dir, VCPKG_LINE_INFO);`
	`1174`	`+`
`1171`	`1175`	`auto cmd = Command{"curl"}`
`1172`	`1176`	`.string_arg("--fail")`
`1173`	`1177`	`.string_arg("--retry")`