Enable extracting 7zNNNN-x64.exe with win32_extract_self_extracting_7z #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I would appreciate if folks have good ideas on testing this but 🤷 |
JavierMatosD
approved these changes
Oct 8, 2024
Contributor
There was a problem hiding this comment.
Thanks for fixing this @BillyONeal!
I would appreciate if folks have good ideas on testing this but 🤷
There is a command.z-extract.ps1 in the end to end tests. We could just check in the .7z.exe and just
$out = Join-Path $TestingRoot "Testing 7zNNN-7z.exe"
Run-Vcpkg z-extract "$PSScriptRoot/../e2e-assets/extract/7zNNN-x64.7z.exe" $out
Throw-IfFailed
?
Member
Author
I don't want to do that because it creates license taint in the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.