Make e2e tests slightly more explicit and consistent. #1510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e-ports/overlaysand just hoist the contents up toe2e-portsdirectly.e2e-ports/overlay-tripletsand hoist that directory to a peer ofe2e-ports. (triplets are not ports and should not be in a directory named ports)e2e-ports/overlaysas an overlay-ports flag in front of all tests. This causes 'spooky action at a distance' where it's harder to review what a test is testing for as what the test actually depends on was not named in the test.--x-builtin-ports-rootrather than--overlay-ports. I believe it would be good to break any dependency on a "real" vcpkg-root to run e2e tests, but several tests need e.g.vcpkg-cmakeandvcpkg-cmake-configto exist, so I've left that as outside the scope of this change.Drive-by change:
end-to-end-tests.ps1to help when making changes like this to avoid N^2 runs :)