Include NuGet console output on failures. #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caching. Prior to this we were dropping NuGet console output on the floor requiring folks to use --debug. There is a behavior change here in that if the exit code was 0 before but the console output included "Authentication may require manual action." we would print a warning anyway, now the warning is only printed on failure. Drive by: Audit for 'Nuget' -> 'NuGet' for correct branding.
BillyONeal
commented
Oct 7, 2025
Comment on lines
-856
to
-861
| if (!m_cmd.push(msg_sink, nupkg_path, nuget_sources_arg({&write_src, 1}))) | ||
| { | ||
| msg_sink.println(Color::error, | ||
| msg::format(msgPushingVendorFailed, msg::vendor = "NuGet", msg::path = write_src) | ||
| .append_raw('\n') | ||
| .append(msgSeeURL, msg::url = docs::troubleshoot_binary_cache_url)); |
Member
Author
There was a problem hiding this comment.
Previously this replaced all rich error information from NuGet with the generic msgPushingVendorFailed. Ditto below
BillyONeal
commented
Oct 7, 2025
Comment on lines
+826
to
+827
| WarningDiagnosticContext wdc{console_diagnostic_context}; | ||
| m_cmd.install(wdc, packages_config, m_packages, m_src); |
Member
Author
There was a problem hiding this comment.
This previously entirely ignored all output from NuGet!
JavierMatosD
approved these changes
Oct 8, 2025
vicroms
approved these changes
Oct 8, 2025
vicroms
pushed a commit
to vicroms/vcpkg-tool
that referenced
this pull request
Oct 9, 2025
Prior to this we were dropping NuGet console output on the floor requiring folks to use --debug. There is a behavior change here in that if the exit code was 0 before but the console output included "Authentication may require manual action." we would print a warning anyway, now the warning is only printed on failure. Drive by: Audit for 'Nuget' -> 'NuGet' for correct branding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report_nonzero_exit_codeandreport_nonzero_exit_code_and_output, and teach to avoid printing the console output when echo_in_debug--debugwill do anything for the push operation. In particular that isn't safe in the face of pipelined uploads and we shouldn't be recommending--debugin any case. (We still claim that--debugdoes something for uploads)Related: microsoft/vcpkg#43309