Skip to content

Use curl_multi_wait rather than curl_multi_poll #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

Use curl_multi_wait rather than curl_multi_poll #1855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/vcpkg/base/downloads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,11 @@ namespace vcpkg
Checks::unreachable(VCPKG_LINE_INFO);
}

mc = curl_multi_poll(multi_handle.get(), nullptr, 0, 1000, nullptr);
// we use curl_multi_wait rather than curl_multi_poll for wider compatibility
mc = curl_multi_wait(multi_handle.get(), nullptr, 0, 1000, nullptr);
if (mc != CURLM_OK)
{
Debug::println("curl_multi_poll failed:");
Debug::println("curl_multi_wait failed:");
Debug::println(msg::format(msgCurlFailedGeneric, msg::exit_code = static_cast<int>(mc))
.append_raw(fmt::format(" ({}).", curl_multi_strerror(mc))));
Checks::unreachable(VCPKG_LINE_INFO);
Expand Down
Loading