Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmilib] Cleanup, de-vendor libs, fix linux #29834

Merged
merged 10 commits into from
Mar 15, 2023
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 24, 2023

Forked from #29805 (change to github):

  • Devendor expat, minizip, zlib.
    Fixes [fmilib] Build error #27890
    The unofficial config carries the transitive usage requirements.
    (Note that upstream did try to embed to everything into a single convenience library including those deps.)
  • Portably compose the final static lib from each lib's target objects instead of platform-specific combining of the individual libs.
    (Removes libtool dependency on osx.)
  • Use "supports" in manifest, remove port from ci.baseline.
  • Cleanup obsolete patching.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt

This comment was marked as outdated.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 24, 2023
@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 24, 2023

The last build creates an libfmilib.a of app. 700 KB. This seems reasonable in contrast to 1500 B before.

@dg0yt dg0yt mentioned this pull request Feb 24, 2023
@dg0yt dg0yt marked this pull request as ready for review February 24, 2023 23:10
@MonicaLiu0311
Copy link
Contributor

I reproduced the error of #27890, and it was not fixed by #29805, but was fixed by this PR. So, will pass it.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 10, 2023
@dan-shaw dan-shaw merged commit 2256cc9 into microsoft:master Mar 15, 2023
@dg0yt dg0yt deleted the fmilib branch March 15, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fmilib] Build error
5 participants