Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[check,libsbml] Update, port fixes #34656

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 22, 2023

Updates libsbml.
There is stilled a vendored minizip.

The exported CMake package is called sbml<-static> instead libsml<-static> on !windows, sbmlteam/libsbml#355.
I now made the existing vcpkg "libsbml" polyfill cover all actual installations. This is actually unofficial...

check is used only by libsbml. The problems with that port were hidden not only by CI not building tests, but by the claim that libsbml's tests would only work on !windows... One of the issues fixed now (x64-windows-static):

CMake Error at D:/installed/x64-windows-static/share/check/check-targets.cmake:87 (message):
  The imported target "Check::checkShared" references the file

     "D:/installed/x64-windows-static/debug/bin/checkDynamic.dll"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "D:/installed/x64-windows-static/share/check/check-targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  D:/installed/x64-windows-static/share/check/check-config.cmake:26 (include)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:680 (find_package)

@dg0yt dg0yt changed the title [libsbml] Update, port fixes [check,libsbml] Update, port fixes Oct 22, 2023
@dg0yt dg0yt marked this pull request as ready for review October 22, 2023 14:49
@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision labels Oct 23, 2023
@jimwang118
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2023
Comment on lines 31 to 33
+ if(NOT TARGET BZ2::BZ2)
+ endif()
+ find_package(BZip2 REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this find_package is supposed to be inside the if statement?

Suggested change
+ if(NOT TARGET BZ2::BZ2)
+ endif()
+ find_package(BZip2 REQUIRED)
+ if(NOT TARGET BZ2::BZ2)
+ find_package(BZip2 REQUIRED)
+ endif()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It is meant to be called without guard.

@JavierMatosD JavierMatosD marked this pull request as draft October 23, 2023 18:25
@JavierMatosD JavierMatosD marked this pull request as ready for review October 23, 2023 20:23
@JavierMatosD JavierMatosD merged commit 4ff2d52 into microsoft:master Oct 24, 2023
15 checks passed
@dg0yt dg0yt deleted the libsbml branch October 24, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants