-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[check,libsbml] Update, port fixes #34656
Conversation
All features passed with following triplets:
|
ports/libsbml/dependencies.diff
Outdated
+ if(NOT TARGET BZ2::BZ2) | ||
+ endif() | ||
+ find_package(BZip2 REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this find_package is supposed to be inside the if statement?
+ if(NOT TARGET BZ2::BZ2) | |
+ endif() | |
+ find_package(BZip2 REQUIRED) | |
+ if(NOT TARGET BZ2::BZ2) | |
+ find_package(BZip2 REQUIRED) | |
+ endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It is meant to be called without guard.
Updates
libsbml
.There is stilled a vendored minizip.
The exported CMake package is called
sbml<-static>
insteadlibsml<-static>
on !windows, sbmlteam/libsbml#355.I now made the existing vcpkg "libsbml" polyfill cover all actual installations. This is actually unofficial...
check
is used only bylibsbml
. The problems with that port were hidden not only by CI not building tests, but by the claim thatlibsbml
's tests would only work on !windows... One of the issues fixed now (x64-windows-static):