[filament] add Filament port #41916

aminya · 2024-11-02T12:42:07Z

This adds Google/Filament

This is a successor of #17369

aminya · 2024-11-02T17:35:26Z

The linker fails to find some of the libraries although their targets are linked in CMake. Any clue why this happens?

[174/500] : && /usr/lib/llvm-18/bin/clang++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fcolor-diagnostics -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/cmgen/CMakeFiles/cmgen.dir/src/cmgen.cpp.o tools/cmgen/CMakeFiles/cmgen.dir/src/ProgressUpdater.cpp.o -o tools/cmgen/cmgen  libs/ibl/libibl.a  libs/imageio/libimageio.a  third_party/getopt/libgetopt.a  libs/image/libimage.a  libs/math/libmath.a  libs/utils/libutils.a  -ldl  -lpng  -ltinyexr  -lz  -lbasis_encoder && :
FAILED: tools/cmgen/cmgen 
: && /usr/lib/llvm-18/bin/clang++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fcolor-diagnostics -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/cmgen/CMakeFiles/cmgen.dir/src/cmgen.cpp.o tools/cmgen/CMakeFiles/cmgen.dir/src/ProgressUpdater.cpp.o -o tools/cmgen/cmgen  libs/ibl/libibl.a  libs/imageio/libimageio.a  third_party/getopt/libgetopt.a  libs/image/libimage.a  libs/math/libmath.a  libs/utils/libutils.a  -ldl  -lpng  -ltinyexr  -lz  -lbasis_encoder && :
/usr/bin/ld: cannot find -ltinyexr: No such file or directory
/usr/bin/ld: cannot find -lbasis_encoder: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

dg0yt · 2024-11-02T17:53:42Z

I don't see any -L flags.

dg0yt · 2024-11-02T17:55:28Z

Maybe the "targets" are not targets where they are used? They are not namespaced, so you don't get good diagnostics. Try using the GLOBAL option to find_package.

aminya · 2024-11-04T06:30:44Z

Maybe the "targets" are not targets where they are used? They are not namespaced, so you don't get good diagnostics. Try using the GLOBAL option to find_package.

Thanks, I added GLOBAL and it fixed the issue!

dg0yt · 2024-11-04T06:45:58Z

Maybe the "targets" are not targets where they are used? They are not namespaced, so you don't get good diagnostics. Try using the GLOBAL option to find_package.

Thanks, I added GLOBAL and it fixed the issue!

Thanks for the feedback. Taken as an example to https://gitlab.kitware.com/cmake/cmake/-/issues/25866.

aminya · 2024-11-04T06:52:10Z

It seems all the build system issues are resolved. Now, I am hitting some linker errors because of the differences between how Filament uses its vendored Glslang, spirv, civetweb, etc.

[206/500] : && /usr/lib/llvm-18/bin/clang++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fcolor-diagnostics -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matc/CMakeFiles/matc.dir/src/main.cpp.o -o tools/matc/matc  tools/matc/libmatlang.a  third_party/getopt/libgetopt.a  libs/filamat/libfilamat.a  shaders/libshaders.a  third_party/smol-v/tnt/libsmol-v.a  -Wl,--start-group  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  -Wl,--end-group  libs/filabridge/libfilabridge.a  libs/math/libmath.a  libs/utils/libutils.a  -ldl && :
FAILED: tools/matc/matc 
: && /usr/lib/llvm-18/bin/clang++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fcolor-diagnostics -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matc/CMakeFiles/matc.dir/src/main.cpp.o -o tools/matc/matc  tools/matc/libmatlang.a  third_party/getopt/libgetopt.a  libs/filamat/libfilamat.a  shaders/libshaders.a  third_party/smol-v/tnt/libsmol-v.a  -Wl,--start-group  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  -Wl,--end-group  libs/filabridge/libfilabridge.a  libs/math/libmath.a  libs/utils/libutils.a  -ldl && :
/usr/bin/ld: warning: shaders.S.o: missing .note.GNU-stack section implies executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `filamat::GLSLPostProcessor::spirvToMsl(std::vector<unsigned int, std::allocator<unsigned int> > const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, filament::backend::ShaderStage, filament::backend::ShaderModel, bool, std::array<utils::FixedCapacityVector<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> >, std::allocator<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> > >, true>, 4ul> const&, filamat::ShaderMinifier const*)':
./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/filamat/src/GLSLPostProcessor.cpp:350:(.text+0x931): undefined reference to `spirv_cross::CompilerMSL::CompilerMSL(std::vector<unsigned int, std::allocator<unsigned int> >)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/filamat/src/GLSLPostProcessor.cpp:453:(.text+0x1208): undefined reference to `spirv_cross::CompilerMSL::add_dynamic_buffer(unsigned int, unsigned int, unsigned int)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/filamat/src/GLSLPostProcessor.cpp:482:(.text+0x161a): undefined reference to `spirv_cross::CompilerMSL::add_msl_resource_binding(spirv_cross::MSLResourceBinding const&)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/filamat/src/GLSLPostProcessor.cpp:484:(.text+0x1632): undefined reference to `spirv_cross::CompilerMSL::compile[abi:cxx11]()'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `filamat::GLSLPostProcessor::spirvToMsl(std::vector<unsigned int, std::allocator<unsigned int> > const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, filament::backend::ShaderStage, filament::backend::ShaderModel, bool, std::array<utils::FixedCapacityVector<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> >, std::allocator<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> > >, true>, 4ul> const&, filamat::ShaderMinifier const*)::$_0::operator()(unsigned int, unsigned int) const':
./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/filamat/src/GLSLPostProcessor.cpp:392:(.text+0x18d1): undefined reference to `spirv_cross::CompilerMSL::add_msl_resource_binding(spirv_cross::MSLResourceBinding const&)'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `filamat::GLSLPostProcessor::optimizeSpirv(std::shared_ptr<spvtools::Optimizer>, std::vector<unsigned int, std::allocator<unsigned int> >&) const':
./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/filamat/src/GLSLPostProcessor.cpp:847:(.text+0x3f50): undefined reference to `spv::spirvbin_t::remap(std::vector<unsigned int, std::allocator<unsigned int> >&, unsigned int)'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spv::spirvbin_t::registerErrorHandler(std::function<void (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>)':
./installed/x64-linux/include/glslang/SPIRV/SPVRemapper.h:121:(.text._ZN3spv10spirvbin_t20registerErrorHandlerESt8functionIFvRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEE[_ZN3spv10spirvbin_t20registerErrorHandlerESt8functionIFvRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEE]+0x12): undefined reference to `spv::spirvbin_t::errorHandler[abi:cxx11]'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spirv_cross::CompilerMSL::~CompilerMSL()':
./installed/x64-linux/include/spirv_cross/spirv_msl.hpp:291:(.text._ZN11spirv_cross11CompilerMSLD2Ev[_ZN11spirv_cross11CompilerMSLD2Ev]+0x17): undefined reference to `vtable for spirv_cross::CompilerMSL'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spv::spirvbin_t::spirvbin_t(int)':
./installed/x64-linux/include/glslang/SPIRV/SPVRemapper.h:105:(.text._ZN3spv10spirvbin_tC2Ei[_ZN3spv10spirvbin_tC2Ei]+0x1a): undefined reference to `vtable for spv::spirvbin_t'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spv::spirvbin_t::~spirvbin_t()':
./installed/x64-linux/include/glslang/SPIRV/SPVRemapper.h:107:(.text._ZN3spv10spirvbin_tD2Ev[_ZN3spv10spirvbin_tD2Ev]+0x17): undefined reference to `vtable for spv::spirvbin_t'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
[207/500] : && /usr/lib/llvm-18/bin/clang++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fcolor-diagnostics -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matinfo/CMakeFiles/matinfo.dir/src/main.cpp.o -o tools/matinfo/matinfo  libs/matdbg/libmatdbg.a  libs/filaflat/libfilaflat.a  third_party/getopt/libgetopt.a  ./installed/x64-linux/debug/lib/libcivetweb.a  ./installed/x64-linux/debug/lib/libz.a  libs/filamat/libfilamat.a  libs/filabridge/libfilabridge.a  libs/math/libmath.a  third_party/smol-v/tnt/libsmol-v.a  shaders/libshaders.a  -Wl,--start-group  -Wl,--end-group  libs/matdbg/libmatdbg_resources.a  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  libs/utils/libutils.a  -ldl && :
FAILED: tools/matinfo/matinfo 
: && /usr/lib/llvm-18/bin/clang++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fcolor-diagnostics -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matinfo/CMakeFiles/matinfo.dir/src/main.cpp.o -o tools/matinfo/matinfo  libs/matdbg/libmatdbg.a  libs/filaflat/libfilaflat.a  third_party/getopt/libgetopt.a  ./installed/x64-linux/debug/lib/libcivetweb.a  ./installed/x64-linux/debug/lib/libz.a  libs/filamat/libfilamat.a  libs/filabridge/libfilabridge.a  libs/math/libmath.a  third_party/smol-v/tnt/libsmol-v.a  shaders/libshaders.a  -Wl,--start-group  -Wl,--end-group  libs/matdbg/libmatdbg_resources.a  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  libs/utils/libutils.a  -ldl && :
/usr/bin/ld: warning: matdbg_resources.S.o: missing .note.GNU-stack section implies executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `filament::matdbg::DebugServer::DebugServer(filament::backend::Backend, int)':
./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/matdbg/src/DebugServer.cpp:155:(.text+0x36f): undefined reference to `CivetServer::CivetServer(char const**, CivetCallbacks const*, void const*)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/matdbg/src/DebugServer.cpp:166:(.text+0x547): undefined reference to `CivetServer::addHandler(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CivetHandler*)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/matdbg/src/DebugServer.cpp:167:(.text+0x5cd): undefined reference to `CivetServer::addHandler(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CivetHandler*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `filament::matdbg::DebugServer::~DebugServer()':
./buildtrees/filament/src/v1.55.0-5cc38bf927/libs/matdbg/src/DebugServer.cpp:176:(.text+0x817): undefined reference to `CivetServer::close()'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `CivetHandler::CivetHandler()':
./installed/x64-linux/include/CivetServer.h:51:(.text._ZN12CivetHandlerC2Ev[_ZN12CivetHandlerC2Ev]+0xf): undefined reference to `vtable for CivetHandler'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x28): undefined reference to `CivetHandler::handleGet(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x30): undefined reference to `CivetHandler::handlePost(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x38): undefined reference to `CivetHandler::handlePost(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x40): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x48): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x50): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x58): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x60): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x68): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x70): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x78): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x80): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x88): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTIN8filament6matdbg18FileRequestHandlerE[_ZTIN8filament6matdbg18FileRequestHandlerE]+0x10): undefined reference to `typeinfo for CivetHandler'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x28): undefined reference to `CivetHandler::handleGet(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x38): undefined reference to `CivetHandler::handlePost(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x40): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x48): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x50): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x58): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x60): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x68): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x70): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x78): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x80): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0x88): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro+0xa0): undefined reference to `typeinfo for CivetHandler'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

dg0yt · 2024-11-04T07:17:27Z

Now, I am hitting some linker errors because of the differences between how Filament uses its vendored Glslang, spirv, civetweb, etc.

Maybe that's a good intermediate result? Without de-vendoring, such issues might be offloaded to the users of vpckg ports...

aminya · 2024-11-05T05:53:06Z

Now, I am hitting some linker errors because of the differences between how Filament uses its vendored Glslang, spirv, civetweb, etc.

Maybe that's a good intermediate result? Without de-vendoring, such issues might be offloaded to the users of vpckg ports...

Yes, it's a good progress. However, the issue is happening because of de-vendoring. They use custom CMake for glslang, spirv, civetweb, and the versions they use are different from the vcpkg versions.

I tried with GCC, and I get a similar error. Inside the CI, there are other errors that must be resolved.

[206/500] : && /usr/bin/g++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matc/CMakeFiles/matc.dir/src/main.cpp.o -o tools/matc/matc -L/usr/lib/gcc/x86_64-linux-gnu/13 tools/matc/libmatlang.a  third_party/getopt/libgetopt.a  libs/filamat/libfilamat.a  shaders/libshaders.a  third_party/smol-v/tnt/libsmol-v.a  -Wl,--start-group  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  -Wl,--end-group  libs/filabridge/libfilabridge.a  libs/math/libmath.a  libs/utils/libutils.a  -ldl && :
FAILED: tools/matc/matc 
: && /usr/bin/g++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matc/CMakeFiles/matc.dir/src/main.cpp.o -o tools/matc/matc -L/usr/lib/gcc/x86_64-linux-gnu/13 tools/matc/libmatlang.a  third_party/getopt/libgetopt.a  libs/filamat/libfilamat.a  shaders/libshaders.a  third_party/smol-v/tnt/libsmol-v.a  -Wl,--start-group  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  -Wl,--end-group  libs/filabridge/libfilabridge.a  libs/math/libmath.a  libs/utils/libutils.a  -ldl && :
/usr/bin/ld: warning: shaders.S.o: missing .note.GNU-stack section implies executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `filamat::GLSLPostProcessor::spirvToMsl(std::vector<unsigned int, std::allocator<unsigned int> > const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, filament::backend::ShaderStage, filament::backend::ShaderModel, bool, std::array<utils::FixedCapacityVector<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> >, std::allocator<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> > >, true>, 4ul> const&, filamat::ShaderMinifier const*)::{lambda(unsigned int, unsigned int)#1}::operator()(unsigned int, unsigned int) const':
./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/filamat/src/GLSLPostProcessor.cpp:392:(.text+0x1366): undefined reference to `spirv_cross::CompilerMSL::add_msl_resource_binding(spirv_cross::MSLResourceBinding const&)'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `filamat::GLSLPostProcessor::spirvToMsl(std::vector<unsigned int, std::allocator<unsigned int> > const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, filament::backend::ShaderStage, filament::backend::ShaderModel, bool, std::array<utils::FixedCapacityVector<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> >, std::allocator<std::tuple<utils::CString, filament::backend::DescriptorSetLayoutBinding, std::optional<filament::SamplerInterfaceBlock::SamplerInfo> > >, true>, 4ul> const&, filamat::ShaderMinifier const*)':
    ./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/filamat/src/GLSLPostProcessor.cpp:350:(.text+0x1411): undefined reference to `spirv_cross::CompilerMSL::CompilerMSL(std::vector<unsigned int, std::allocator<unsigned int> >)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/filamat/src/GLSLPostProcessor.cpp:453:(.text+0x1b0c): undefined reference to `spirv_cross::CompilerMSL::add_dynamic_buffer(unsigned int, unsigned int, unsigned int)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/filamat/src/GLSLPostProcessor.cpp:482:(.text+0x1dc6): undefined reference to `spirv_cross::CompilerMSL::add_msl_resource_binding(spirv_cross::MSLResourceBinding const&)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/filamat/src/GLSLPostProcessor.cpp:484:(.text+0x1ddf): undefined reference to `spirv_cross::CompilerMSL::compile[abi:cxx11]()'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `filamat::GLSLPostProcessor::optimizeSpirv(std::shared_ptr<spvtools::Optimizer>, std::vector<unsigned int, std::allocator<unsigned int> >&) const':
./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/filamat/src/GLSLPostProcessor.cpp:847:(.text+0x3d5b): undefined reference to `spv::spirvbin_t::remap(std::vector<unsigned int, std::allocator<unsigned int> >&, unsigned int)'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spv::spirvbin_t::spirvbin_t(int)':
./installed/x64-linux/include/glslang/SPIRV/SPVRemapper.h:104:(.text._ZN3spv10spirvbin_tC2Ei[_ZN3spv10spirvbin_tC5Ei]+0x16): undefined reference to `vtable for spv::spirvbin_t'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spv::spirvbin_t::~spirvbin_t()':
./installed/x64-linux/include/glslang/SPIRV/SPVRemapper.h:107:(.text._ZN3spv10spirvbin_tD2Ev[_ZN3spv10spirvbin_tD5Ev]+0x13): undefined reference to `vtable for spv::spirvbin_t'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spv::spirvbin_t::registerErrorHandler(std::function<void (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>)':
./installed/x64-linux/include/glslang/SPIRV/SPVRemapper.h:121:(.text._ZN3spv10spirvbin_t20registerErrorHandlerESt8functionIFvRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEE[_ZN3spv10spirvbin_t20registerErrorHandlerESt8functionIFvRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEE]+0x1a): undefined reference to `spv::spirvbin_t::errorHandler[abi:cxx11]'
/usr/bin/ld: libs/filamat/libfilamat.a(GLSLPostProcessor.cpp.o): in function `spirv_cross::CompilerMSL::~CompilerMSL()':
./installed/x64-linux/include/spirv_cross/spirv_msl.hpp:291:(.text._ZN11spirv_cross11CompilerMSLD2Ev[_ZN11spirv_cross11CompilerMSLD5Ev]+0x13): undefined reference to `vtable for spirv_cross::CompilerMSL'
collect2: error: ld returned 1 exit status
[207/500] : && /usr/bin/g++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matinfo/CMakeFiles/matinfo.dir/src/main.cpp.o -o tools/matinfo/matinfo -L/usr/lib/gcc/x86_64-linux-gnu/13 libs/matdbg/libmatdbg.a  libs/filaflat/libfilaflat.a  third_party/getopt/libgetopt.a  ./installed/x64-linux/debug/lib/libcivetweb.a  ./installed/x64-linux/debug/lib/libz.a  libs/filamat/libfilamat.a  libs/filabridge/libfilabridge.a  libs/math/libmath.a  third_party/smol-v/tnt/libsmol-v.a  shaders/libshaders.a  -Wl,--start-group  -Wl,--end-group  libs/matdbg/libmatdbg_resources.a  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  libs/utils/libutils.a  -ldl && :
FAILED: tools/matinfo/matinfo 
: && /usr/bin/g++ -fPIC -std=c++17 -fstrict-aliasing -Wno-unknown-pragmas -Wno-unused-function -Wno-deprecated-declarations -fPIC -fvisibility=hidden -DTNT_DEV -g -fstack-protector -Wl,--gc-sections tools/matinfo/CMakeFiles/matinfo.dir/src/main.cpp.o -o tools/matinfo/matinfo -L/usr/lib/gcc/x86_64-linux-gnu/13 libs/matdbg/libmatdbg.a  libs/filaflat/libfilaflat.a  third_party/getopt/libgetopt.a  ./installed/x64-linux/debug/lib/libcivetweb.a  ./installed/x64-linux/debug/lib/libz.a  libs/filamat/libfilamat.a  libs/filabridge/libfilabridge.a  libs/math/libmath.a  third_party/smol-v/tnt/libsmol-v.a  shaders/libshaders.a  -Wl,--start-group  -Wl,--end-group  libs/matdbg/libmatdbg_resources.a  ./installed/x64-linux/debug/lib/libSPIRV.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libglslang.a  ./installed/x64-linux/debug/lib/libMachineIndependent.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools-opt.a  ./installed/x64-linux/debug/lib/libspirv-cross-glsl.a  ./installed/x64-linux/debug/lib/libspirv-cross-core.a  ./installed/x64-linux/debug/lib/libSPIRV-Tools.a  -lrt  libs/utils/libutils.a  -ldl && :
/usr/bin/ld: warning: matdbg_resources.S.o: missing .note.GNU-stack section implies executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `filament::matdbg::DebugServer::DebugServer(filament::backend::Backend, int)':
./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/matdbg/src/DebugServer.cpp:155:(.text+0x4f6): undefined reference to `CivetServer::CivetServer(char const**, CivetCallbacks const*, void const*)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/matdbg/src/DebugServer.cpp:166:(.text+0x63a): undefined reference to `CivetServer::addHandler(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CivetHandler*)'
/usr/bin/ld: ./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/matdbg/src/DebugServer.cpp:167:(.text+0x6ae): undefined reference to `CivetServer::addHandler(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CivetHandler*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `filament::matdbg::DebugServer::~DebugServer()':
./buildtrees/filament/src/v1.55.0-8c9bcb1d21/libs/matdbg/src/DebugServer.cpp:176:(.text+0x895): undefined reference to `CivetServer::close()'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `CivetHandler::~CivetHandler()':
./installed/x64-linux/include/CivetServer.h:58:(.text._ZN12CivetHandlerD2Ev[_ZN12CivetHandlerD5Ev]+0xf): undefined reference to `vtable for CivetHandler'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o): in function `CivetHandler::CivetHandler()':
./installed/x64-linux/include/CivetServer.h:51:(.text._ZN12CivetHandlerC2Ev[_ZN12CivetHandlerC5Ev]+0xf): undefined reference to `vtable for CivetHandler'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x28): undefined reference to `CivetHandler::handleGet(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x30): undefined reference to `CivetHandler::handlePost(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x38): undefined reference to `CivetHandler::handlePost(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x40): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x48): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x50): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x58): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x60): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x68): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x70): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x78): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x80): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg18FileRequestHandlerE[_ZTVN8filament6matdbg18FileRequestHandlerE]+0x88): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(DebugServer.cpp.o):(.data.rel.ro._ZTIN8filament6matdbg18FileRequestHandlerE[_ZTIN8filament6matdbg18FileRequestHandlerE]+0x10): undefined reference to `typeinfo for CivetHandler'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x28): undefined reference to `CivetHandler::handleGet(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x38): undefined reference to `CivetHandler::handlePost(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x40): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x48): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x50): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x58): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x60): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x68): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x70): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x78): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x80): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTVN8filament6matdbg10ApiHandlerE[_ZTVN8filament6matdbg10ApiHandlerE]+0x88): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*, int*)'
/usr/bin/ld: libs/matdbg/libmatdbg.a(ApiHandler.cpp.o):(.data.rel.ro._ZTIN8filament6matdbg10ApiHandlerE[_ZTIN8filament6matdbg10ApiHandlerE]+0x10): undefined reference to `typeinfo for CivetHandler'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

aminya · 2024-11-06T14:16:18Z

Got a successful build with Clang on Linux! 🎉

Update portfile.cmake

Update filament.json

aminya · 2024-11-07T09:02:05Z

Getting Filament to build with gcc is too much work. There are numerous compiler errors that need to be resolved, which is out of the scope of this PR. I have added the clang requirement in the port for Linux.

dg0yt · 2024-11-07T11:50:12Z

ports/filament/portfile.cmake

+    vcpkg_find_acquire_program(CLANG)
+    set(COMPILER -DCMAKE_CXX_COMPILER=${CLANG}++ -DCMAKE_C_COMPILER=${CLANG})


Ports must not change the compiler like this.
CI can expect it to fail via scripts/ci.baseline.txt.

The portfile can print a message. (If you want a conditional message, you could vcpkg_cmake_get_vars.)

Why not? Ports can have compiler requirements, and this line declares that. I patched the original CMake not to error on gcc, but if vcpkg is against that, I will revert that patch. The compilation fails with gcc towards the ends. It is quite wasteful not to error out early and let the users know about the clang requirement.
I'd either keep the original requirement in CMakeLists.txt or here in vcpkg.

Another benefit of keeping this in vcpkg is that we can build filament with clang but link to it from gcc. Not having this, forces the users to use Clang for everything!

The toolchain - including compiler - is controlled by the triplet. Users may use per-port customization in triplet files.

To error out early, use vcpkg_cmake_get_vars to get toolchain information.

What about using gcc with clang built Filament? Not having this makes it unnecessarily hard.

ports/filament/usage

dg0yt · 2024-11-08T08:44:35Z

The CMake config package is not provided by upstream. So the package name must be unofficial-filament, the target namespace must be unofficial::filament::, and the config installation dir must be changed accordingly.

LilyWangLL · 2024-11-12T09:54:05Z

Please fix the build error:

CMake Error at CMakeLists.txt:942 (get_target_property):
  get_target_property() called with non-existent target "SPIRV-Headers".


CMake Error at CMakeLists.txt:943 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  SPIRV-Headers


CMake Error at CMakeLists.txt:947 (install):
  install TARGETS given target "SPIRV-Headers" which does not exist.


CMake Error at CMakeLists.txt:948 (export):
  export given target "SPIRV-Headers" which is not built by this project.


CMake Error at CMakeLists.txt:967 (install):
  install TARGETS given target "bluevk" which does not exist.


CMake Error at CMakeLists.txt:968 (export):
  export given target "bluevk" which is not built by this project.

aminya · 2024-11-26T05:37:04Z

I am waiting upstream to merge the changes. I didn't wanna add the unofficial prefix as it doesn't make sense to me.

dg0yt · 2024-11-26T06:19:08Z

I am waiting upstream to merge the changes. I didn't wanna add the unofficial prefix as it doesn't make sense to me.

google/filament#8267

It is a pity that you didn't leave a note.
We don't know the reason for delay.
We can't review the upstream PR.
And we can't learn from having it already as unofficial in vcpkg.

dg0yt · 2024-11-26T06:24:51Z

The upstream PR has changes to directories with third-party code. vk_mem_alloc.h also lives in port vulkan-memory-allocator. So there might be more work to be done.

aminya mentioned this pull request Nov 2, 2024

[open3d] add Open3D port #41844

Draft

11 tasks

aminya force-pushed the filament branch 2 times, most recently from 24a9023 to 2926a79 Compare November 2, 2024 14:29

jimwang118 assigned LilyWangLL Nov 4, 2024

aminya force-pushed the filament branch from 24f76bb to 9b0b85e Compare November 4, 2024 06:48

LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 4, 2024

aminya added 15 commits November 6, 2024 07:44

[filament] add Filament port

7e0dc82

[filament] add patch to disable tests/benchmarks

38ff8e0

Update portfile.cmake

[filament] prefer external packages

cfefea2

[filament] fix basisu includes/property name

f4ac927

[filament] fix miktspace include

3b865f2

[filament] fix glslang includes

3fe25d3

[glslang] allow installation of private headers

8c9615a

[filament] install private glslang headers

71b3eba

[filament] do not list licenses for external packages

4e6a7ce

Update filament.json

[glslang] install all the private headers

6da135c

[filament] fix all glslang includes

34791bc

[filament] do not use libc++

549fc2f

[filament] fix finding of external libraries/licenses

9eb6dc0

[filament] use the built-in cross-platform getopt

133e5ad

[filament] fix the basisu alias names

c06578b

aminya added 4 commits November 6, 2024 07:44

[filament] fix spirv-cross-msl linkage

40685ec

[filament] fix const qualifier for remote server

57296a6

[filament] fix std::memcpy

991ae22

[filament] fix snprintf include

7c15483

aminya force-pushed the filament branch from 704023c to 683740f Compare November 6, 2024 15:49

[filament] add zstd dependency

485d852

aminya force-pushed the filament branch from 683740f to 485d852 Compare November 6, 2024 15:49

[filament] fix public includes for the targets

8c37176

aminya marked this pull request as ready for review November 6, 2024 18:25

aminya force-pushed the filament branch from b07655c to eab8d28 Compare November 7, 2024 07:43

aminya added 2 commits November 6, 2024 23:51

[filament] fix macos needing gtest

92cbf7d

[filament] support find_package filament

ea18b6b

aminya force-pushed the filament branch from eab8d28 to ea18b6b Compare November 7, 2024 07:54

aminya added 3 commits November 7, 2024 00:52

[filament] fix gcc compilation errors

3b68e4c

[filament] require clang on Linux due to numerous compiler errors

8698aac

[filament] require C++-17

b60ae89

dg0yt reviewed Nov 7, 2024

View reviewed changes

This was referenced Nov 10, 2024

feat: support optional finding of externals instead of subdirectories google/filament#8266

Open

feat: support installing and finding filament via find_package google/filament#8267

Draft

feat: add options to disable tests/benchmarks google/filament#8245

Open

LilyWangLL marked this pull request as draft November 12, 2024 09:54

LilyWangLL closed this Nov 26, 2024

LilyWangLL reopened this Nov 26, 2024

LilyWangLL added the depends:upstream-changes Waiting on a change to the upstream project label Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[filament] add Filament port #41916

[filament] add Filament port #41916

aminya commented Nov 2, 2024 •

edited

Loading

aminya commented Nov 2, 2024

dg0yt commented Nov 2, 2024

dg0yt commented Nov 2, 2024

aminya commented Nov 4, 2024

dg0yt commented Nov 4, 2024

aminya commented Nov 4, 2024 •

edited

Loading

dg0yt commented Nov 4, 2024

aminya commented Nov 5, 2024 •

edited

Loading

aminya commented Nov 6, 2024 •

edited

Loading

aminya commented Nov 7, 2024

dg0yt Nov 7, 2024

aminya Nov 7, 2024 •

edited

Loading

dg0yt Nov 7, 2024

aminya Nov 7, 2024

dg0yt commented Nov 8, 2024

LilyWangLL commented Nov 12, 2024

aminya commented Nov 26, 2024

dg0yt commented Nov 26, 2024 •

edited

Loading

dg0yt commented Nov 26, 2024

		vcpkg_find_acquire_program(CLANG)
		set(COMPILER -DCMAKE_CXX_COMPILER=${CLANG}++ -DCMAKE_C_COMPILER=${CLANG})

[filament] add Filament port #41916

Are you sure you want to change the base?

[filament] add Filament port #41916

Conversation

aminya commented Nov 2, 2024 • edited Loading

aminya commented Nov 2, 2024

dg0yt commented Nov 2, 2024

dg0yt commented Nov 2, 2024

aminya commented Nov 4, 2024

dg0yt commented Nov 4, 2024

aminya commented Nov 4, 2024 • edited Loading

dg0yt commented Nov 4, 2024

aminya commented Nov 5, 2024 • edited Loading

aminya commented Nov 6, 2024 • edited Loading

aminya commented Nov 7, 2024

dg0yt Nov 7, 2024

Choose a reason for hiding this comment

aminya Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

dg0yt Nov 7, 2024

Choose a reason for hiding this comment

aminya Nov 7, 2024

Choose a reason for hiding this comment

dg0yt commented Nov 8, 2024

LilyWangLL commented Nov 12, 2024

aminya commented Nov 26, 2024

dg0yt commented Nov 26, 2024 • edited Loading

dg0yt commented Nov 26, 2024

aminya commented Nov 2, 2024 •

edited

Loading

aminya commented Nov 4, 2024 •

edited

Loading

aminya commented Nov 5, 2024 •

edited

Loading

aminya commented Nov 6, 2024 •

edited

Loading

aminya Nov 7, 2024 •

edited

Loading

dg0yt commented Nov 26, 2024 •

edited

Loading