-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Deindex several ports that were =skip or broken. #42222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removes several ports from the registry that conflict with others and/or are effectively untested in vcpkg's build lab. [cppmicroservices] This port was added 5 years ago, appears relatively unused, only exists in repology due to vcpkg, and is full of vendored dependencies. It's also broken for most official triplets. Replaces microsoft#34552 [ijg-libjpeg, mozjpeg] Leaf ports that we can't test and conflict with libjpeg-turbo, the curated registry's canonical jpeg implementation. [optional-bare] Conflicted with optional-lite. [qt5-canvas3d] Removed by qt5 upstream. [range-v3-vs2015] No longer maintained by upstream, no longer necessary in 2024. [rbdl-orb] File conflicts with its own dependency. [sciter] Left support by upstream 2 years ago and has conflicts with other ports. [signalrclient] "Obsolete" and conflicts with microsoft-signalr [spdk-*] Several conflicts with other ports. [c-dbg-macro] Conflicts with [dbg-macro] [casadi] microsoft#41649 appears to have been merged in error, casadi/casadi#3896 needs to land before this can be in the curated registry. Moreover, problems in the portfile were skipped in ci.baseline.txt rather than a supports expression. We are happy to bring this port back as soon as that issue is fixed :) [chromium-base] Not tested anywhere for years. [libmesh] Conflicts with other ports. [libpng-apng] Doesn't even exist in the first place. [libqcow] Release distribution file contains configured sources, while the source code in the repository does not. [libvmdk] Upstream is gone. [mecab] Upstream has not been edited in 10 years, combination of =skip and supports clause means not tested. [shogun] Not tested. Not deindexed: [bde] Conflicts with other ports. Warning was given more than a year ago: microsoft#32645 . However, microsoft#41335 appears to indicate that it works now, so the =skips were removed. [stxxl] Appears to work on my machine? [chartdir] Unstable download URLs are now mitigated by asset caching. [buck-yeh-bux] Looks like these are intended to be in the supports clause. [boringssl, fluidlite, libressl, libmariadb, libmysql] Appears to have a dedicated userbase despite being untestable in CI. [libxaw] Needed supports expression for ONLY_DYNAMIC_LIBRARY, should have always been a fail not a skip. Related: microsoft#42165
libmariadb builds in CI on android. |
Add ntf-core, previously hidden by skipped bde.
True, we have that funny arrangement for only libmariadb/libmysql. |
Tagging vcpkg-team-review because
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successful builds in CI.
(Not necessarily indicating usefullness.)
"baseline": "1.0.0", | ||
"port-version": 6 | ||
}, | ||
"casadi": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI on linux, osx, windows-dynamic.
"baseline": "0.21.5", | ||
"port-version": 1 | ||
}, | ||
"libqcow": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI on arm64-osx. But known bad. (Related: #36809.)
You could use microsoft/vcpkg-tool#802 to test ports in ci even if they conflict. |
Unfortunately we don't really have the cores available to be adding multiple 'ways' of testing the registry as the pool already gets very behind a lot of the time. And the combinatoric explosion quickly becomes infeasible. |
Yesterday @ras0219-msft, @vicroms, @JavierMatosD and I discussed this and agree that only things which are entirely untested on all platforms should be deindexed in a change like this, under the rationale that we would not add such ports today. I will keep the ones dg0yt noted above and split any remaining ones I think should be removed for other reasons into their own PRs |
…aries. In particular, nvtx was missing.
# Conflicts: # ports/casadi/portfile.cmake # ports/casadi/usage # ports/casadi/vcpkg.json # ports/cppmicroservices/portfile.cmake # ports/cppmicroservices/vcpkg.json # ports/cppmicroservices/werror.patch # ports/ijg-libjpeg/CMakeLists.txt # ports/ijg-libjpeg/portfile.cmake # ports/ijg-libjpeg/vcpkg.json # ports/range-v3-vs2015/portfile.cmake # ports/range-v3-vs2015/vcpkg.json # ports/spdk/CMakeLists.txt # ports/spdk/vcpkg.json # ports/usd/vcpkg.json # scripts/ci.baseline.txt # versions/baseline.json # versions/u-/usd.json
…t-2025 # Conflicts: # scripts/ci.feature.baseline.txt
REGRESSION: blend2d:arm64-uwp failed with BUILD_FAILED. If expected, add blend2d:arm64-uwp=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: blend2d:arm64-windows failed with BUILD_FAILED. If expected, add blend2d:arm64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: blend2d:arm64-windows-static-md failed with BUILD_FAILED. If expected, add blend2d:arm64-windows-static-md=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: opencv4:arm64-uwp failed with BUILD_FAILED. If expected, add opencv4:arm64-uwp=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: vcpkg-ci-opencv:arm64-uwp cascaded, but it is required to pass. (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: saucer:arm64-windows failed with BUILD_FAILED. If expected, add saucer:arm64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: saucer:arm64-windows-static-md failed with BUILD_FAILED. If expected, add saucer:arm64-windows-static-md=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: saucer:x64-windows failed with BUILD_FAILED. If expected, add saucer:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: saucer:x64-windows-static failed with BUILD_FAILED. If expected, add saucer:x64-windows-static=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: saucer:x64-windows-static-md failed with BUILD_FAILED. If expected, add saucer:x64-windows-static-md=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: saucer:x86-windows failed with BUILD_FAILED. If expected, add saucer:x86-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt. All baseline issues identical to https://dev.azure.com/vcpkg/public/_build/results?buildId=119952&view=logs&j=84da4f4a-968a-5b5c-16e9-f444c845396d&t=410b6c71-3bf9-5b7a-84d3-17ae677a92aa |
Did the last image update bring a broken arm64 msvc toolchain? |
Yes and no. Yes, trying to I am seeing an issue where See #47363 |
# Conflicts: # scripts/ci.baseline.txt
The qtapplicationmanager failure will be fixed in #47326 . (I'm not sure why it's only showing up here but I already have a fix for it so I'm not complaining much.) |
# Conflicts: # scripts/ci.baseline.txt
# Conflicts: # scripts/ci.baseline.txt # scripts/ci.feature.baseline.txt
Pull request was closed
Removes several ports from the registry that conflict with others and/or are effectively untested in vcpkg's build lab. "Not tested" claims cross checked with https://dev.azure.com/vcpkg/public/_build/results?buildId=119810
[cppmicroservices] This port was added 5 years ago, appears relatively unused, only exists in repology due to vcpkg, and is full of vendored dependencies. It's also broken for most official triplets. Replaces #34552Appears fixed by #42720[ijg-libjpeg, mozjpeg] Leaf ports that we can't test and conflict with libjpeg-turbo, the curated registry's canonical jpeg implementation.
[optional-bare] Conflicts with optional-lite.
[qt5-canvas3d] Removed by qt5 upstream.
[range-v3-vs2015] No longer maintained by upstream, no longer necessary in 2024.
[rbdl-orb]
File conflicts with its own dependency.It's an empty port.[sciter] Left support by upstream 2 years ago and has conflicts with other ports.
[signalrclient] "Obsolete" and conflicts with microsoft-signalr
[spdk-*] Several conflicts with other ports.
[c-dbg-macro] Conflicts with [dbg-macro]. Was tested on Android but dbg-macro appears to work there so I've resolved the conflict in that direction.
[casadi] #41649 appears to have been merged in error, casadi/casadi#3896 needs to land before this can be in the curated registry. Moreover, problems in the portfile were skipped in ci.baseline.txt rather than a supports expression. We are happy to bring this port back as soon as that issue is fixed :)Appears fixed in #43425[chromium-base] Not tested anywhere for years.
[libmesh] Conflicts with other ports.
[libpng-apng] Doesn't even exist in the first place.
[libqcow] Release distribution file contains configured sources, while the source code in the repository does not.I still think this port is bad but it exists on Linux at least.[libvmdk] Upstream is gone.
[mecab] Upstream has not been edited in 10 years, combination of =skip and supports clause means not tested.Actually tested on x64-osx.Not deindexed:
[bde] Conflicts with other ports. Warning was given more than a year ago: #32645 . However, #41335 appears to indicate that it works now, so the =skips were removed.
[stxxl] Appears to work on my machine?
[chartdir] Unstable download URLs are now mitigated by asset caching.
[buck-yeh-bux] Works on my machine or already skipped by supports clause. The mariadb backend is broken, but it's entirely broken. We should consider deindexing completely, but @buck-yeh appears to be an active contributor here so I want to give them the heads' up before doing anything with it.
[boringssl, fluidlite, libressl, libmariadb, libmysql] Appears to have a dedicated userbase despite being untestable in CI.
[libxaw] Needed supports expression for ONLY_DYNAMIC_LIBRARY, should have always been a fail not a skip.
Related: #42165