Skip to content

Conversation

@snnn
Copy link

@snnn snnn commented Dec 20, 2024

Compared to the current version, the new cpuinfo version has the following changes:

  1. Now it is C only. It no longer requires a C++ compiler
  2. Added several new build options:
    • CPUINFO_LOG_TO_STDIO
    • USE_SYSTEM_LIBS
    • USE_SYSTEM_GOOGLEBENCHMARK
    • USE_SYSTEM_GOOGLETEST
  3. The new code is based on C++14 instead of C++11
  4. Added support for Windows ARM64. But it still has problems with ARM64EC. See: Update cpuinfo.h: add support for Windows ARM64EC pytorch/cpuinfo#227
  5. Added support for WindowsStore
  6. On Android now it links to the log library for logging
  7. It no longer depends on clog and no longer provides the clog target, which is a breaking change and is causing build issues for some OSS libraries(like xnnpack)
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@snnn
Copy link
Author

snnn commented Dec 20, 2024

Need help here: the new cpuinfo version no longer needs clog. The change is causing problems for XNNPack. The new cpuinfo version doesn't work with older versions of XNNPack. So I also need to update XNNPack? But one PR should only update one port. What should I do? And, do I need to delete the older versions of cpuinfo?

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Dec 20, 2024
@LilyWangLL LilyWangLL changed the title Update cpuinfo to the latest version [cpuinfo] Update cpuinfo to the latest version Dec 20, 2024
@JoergAtGithub
Copy link
Contributor

The build fails due to qnnpack and xnnpack. This should be fixed once the huge libtorch update PR #41956 is merged.

@snnn snnn closed this Dec 31, 2024
@JoergAtGithub
Copy link
Contributor

@snnn qnnpack & xnnpack are now finally updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants