Skip to content

[cpprestsdk] fix compilation of cpprestsdk on new MacOS #45373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 5, 2025

Cpprestsdk fails to compile on newer MacOS due to missing char_traits.
Fixes #45131

This provides the fix from microsoft/cpprestsdk#1820
Related to microsoft/cpprestsdk#1812

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Cpprestsdk fails to compile on newer MacOS due to missing char_traits.

This provides the fix from microsoft/cpprestsdk#1820
Related to microsoft/cpprestsdk#1812
@aminya aminya force-pushed the cpprest-char-traits branch from 8f56217 to ce29d3a Compare May 5, 2025 07:47
@@ -1,3 +1,9 @@
vcpkg_download_distfile(PATCH_PR_1820
URLS https://github.com/microsoft/cpprestsdk/commit/396259a0f88e6f908c6d841f13c113d5f0d0ec26.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this commit will disappear when the PR is gone :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. What's the alternative? Vendoring the patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, given that cpprestsdk is a Microsoft repository, is there any chance we can get a speed up in reviewing and merging the original PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. What's the alternative? Vendoring the patch?

Yes, it would have to be included here.

Also, given that cpprestsdk is a Microsoft repository, is there any chance we can get a speed up in reviewing and merging the original PR?

At this point I think either getting taken is unlikely, both because cpprestsdk is effectively dead at this point (there are already several PRs there to fix build breaks on recent platforms which are unreviewed) and because the proposed change introduces undefined behavior.

My own changes have been waiting for literally years too, e.g. microsoft/cpprestsdk#1767

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label May 6, 2025
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2025
Copy link
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't take this patch for the reasons mentioned by @BillyONeal in a previous comment. Mainly, we can't validate for correctness. In the meantime, I will be closing this PR. Please feel free to reopen the PR if you feel it was closed prematurely.

@aminya
Copy link
Contributor Author

aminya commented May 8, 2025

Unfortunately, we can't take this patch for the reasons mentioned by @BillyONeal in a previous comment. Mainly, we can't validate for correctness. In the meantime, I will be closing this PR. Please feel free to reopen the PR if you feel it was closed prematurely.

@BillyONeal @JavierMatosD What's the alternative? The new MacOS changes have broken the builds across several software, including very active ones such as Node.js. Can we update the Azure CI to the latest MacOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cpprestsdk] Build error on arm64-osx
4 participants