-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[cpprestsdk] fix compilation of cpprestsdk on new MacOS #45373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
8f56217
to
ce29d3a
Compare
ports/cpprestsdk/portfile.cmake
Outdated
@@ -1,3 +1,9 @@ | |||
vcpkg_download_distfile(PATCH_PR_1820 | |||
URLS https://github.com/microsoft/cpprestsdk/commit/396259a0f88e6f908c6d841f13c113d5f0d0ec26.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this commit will disappear when the PR is gone :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. What's the alternative? Vendoring the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, given that cpprestsdk is a Microsoft repository, is there any chance we can get a speed up in reviewing and merging the original PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. What's the alternative? Vendoring the patch?
Yes, it would have to be included here.
Also, given that cpprestsdk is a Microsoft repository, is there any chance we can get a speed up in reviewing and merging the original PR?
At this point I think either getting taken is unlikely, both because cpprestsdk is effectively dead at this point (there are already several PRs there to fix build breaks on recent platforms which are unreviewed) and because the proposed change introduces undefined behavior.
My own changes have been waiting for literally years too, e.g. microsoft/cpprestsdk#1767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we can't take this patch for the reasons mentioned by @BillyONeal in a previous comment. Mainly, we can't validate for correctness. In the meantime, I will be closing this PR. Please feel free to reopen the PR if you feel it was closed prematurely.
@BillyONeal @JavierMatosD What's the alternative? The new MacOS changes have broken the builds across several software, including very active ones such as Node.js. Can we update the Azure CI to the latest MacOS? |
Cpprestsdk fails to compile on newer MacOS due to missing char_traits.
Fixes #45131
This provides the fix from microsoft/cpprestsdk#1820
Related to microsoft/cpprestsdk#1812
./vcpkg x-add-version --all
and committing the result.