[embree] Update (embree3) to 4.4.0 [libigl] Test and fix #47815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
microsoft/vcpkg-tool#1817 bug fix |
dg0yt
changed the title
dg0yt
changed the title
4 tasks
BillyONeal
reviewed
Oct 27, 2025
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for the submission and tests!
ports/embree/portfile.cmake
Outdated
| -DEMBREE_STATIC_LIB=${EMBREE_STATIC_LIB} | ||
| -DEMBREE_TASKING_SYSTEM:STRING=${EMBREE_TASKING_SYSTEM} | ||
| -DEMBREE_TUTORIALS=OFF | ||
| -DVCPKG_TRACE_FIND_PACKAGE=ON |
Member
There was a problem hiding this comment.
Suggested change
| -DVCPKG_TRACE_FIND_PACKAGE=ON |
?
Member
There was a problem hiding this comment.
Do we really want to leave trace on?
Member
There was a problem hiding this comment.
Thanks! In the future do you want me to just remove this if I see it again? With my naïve understanding I assumed this would be an investigation only thing that shouldn't stay but I also know that was your feature so I err'd on the side of 'there's got to be some reason he left it here'
Contributor
Author
There was a problem hiding this comment.
I shall add a comment when it needs to be merged (e.g. flaky port).
BillyONeal
added
category:port-bug
BillyONeal
removed
the
info:needs-maintainer-attention
theartful
added a commit
to theartful/polychase
that referenced
this pull request
Nov 22, 2025
Vcpkg finally added it: microsoft/vcpkg#47815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47785.
Resolves #47053. Resolves #35683.
AFAICS there is no acceptable way to install embree 3 and embree 4 simultaneously under vcpkg terms. Embree 4.0.0 was released on Feb 8, 2023, so there was more than two years for reverse dependencies to get ready.
libigl was packaged as "header-only" since #14888 and again since #30617. This PR was developed with the compiled library. IMO this is the better fit for a package manager like vcpkg. It would be more obvious if it would be used by multiple reverse dependencies.
But in the end, I restored the header-only configuration, now subject to a triplet variable.
The libigl port now also applies upstream's defaults for
CGAL_CMAKE_EXACT_NT_BACKEND(BOOST_BACKEND) andCGAL_DISABLE_GMP(ON). In header-only mode, these options are cache variables in the user project.