[zlib] NO_CMAKE_FIND_ROOT_PATH is essential for cross compilation #48512
+10
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.There is a number of reports about broken zlib: #39099, #46924, #38832, #20057 that indicate problem finding an existing file. This is commonly pronounced when cross compiling, say with x64-mingw-dynamic on Linux, as CMAKE_FIND_ROOT_PATH is set and the search is performed in the wrong place. The wrapper script needs
NO_CMAKE_FIND_ROOT_PATHas well.