-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MDN to enhance CSS LS. Part of #68 #91
Conversation
Note that |
I like the use of status. Maybe we should omit |
So, mdn-data is licensed as MPL which is a somewhat copyleft license. This created some major headaches for me when I needed to have a dependency on it and I suspect it may have issues at other companies as well. Maybe at Microsoft if they need to distribute it as part of a vscode bundle. It would be really great if the mdn team would change the license to something like MIT or BSD. But I strongly urge you to clear this issue with legal before landing the patch. |
@aeschli Sure, I can remove it together with a bunch of other unused properties. @chriseppstein Yes, I submitted license review request for mdn/data. Before the review passes we won't ship the change. Meanwhile, can you chime in at mdn/data#199 for your concerns? |
https://www.mozilla.org/en-US/MPL/2.0/FAQ/
We don't do any modification to the original mdn/data source, so vscode-css-languageservice could still be shared under MIT license. |
So, the legal definition of modification isn’t the same as a developer’s definition. I haven’t reviewed this PR in depth yet, but according to the lawyers I’ve worked with there’s a number of build time transformations that meet the legal definition of “modification” and would require a dual license. If you don’t do anything like that, it’s still something that will require an ongoing attention towards. |
@chriseppstein Thanks, I've opened mdn/data#210 |
Collect documentations on CSS properties and compile into mdn-documentation.js. Certain properties are excluded because of inaccurency. - Fix microsoft/vscode#46866 - Fix microsoft/vscode#46423 - Fix microsoft/vscode#27204
This PR:
mdn-data
(can we switch to yarn.lock instead of package-lock.json entirely?)browsers.ts
by combining VSC and MDN data, while giving preference to VSC datasyntax
andstatus
in completion item's documentation.Questions: