-
Notifications
You must be signed in to change notification settings - Fork 77
Add computed Baseline status #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@microsoft-github-policy-service agree |
We don't want to make any breaking changes to the custom data format, just additions. So simply add a new 'baseline' (or `baseline-compatibility') property on the same level as browsers. The value set should be well defined, maybe an enum and a description. This can then go in the schema: https://github.com/microsoft/vscode-CSS-languageservice/blob/main/docs/customData.schema.json and also in the documentation. |
Thanks @aeschli. I've reverted the |
If you open it in in VS Code you will get validation. |
Ok great, I've added this to my local settings and I can confirm that there are no validation warnings in "json.schemas": [
{
"fileMatch": [
"**/web-data/data/browsers.css-data.json"
],
"url": "/Users/rviscomi/git/vscode-css-languageservice/docs/customData.schema.json"
}
] |
Thanks @rviscomi ! |
Progress on microsoft/vscode-css-languageservice#427
npm run update-sources
compute-baseline
dependencybrowsers
fieldnpm run generate-data
I think this also fixes a bug where some pseudo-elements and pseudo-classes might have
()
suffixes that need to get stripped out to match the feature IDs in BCD.See PR microsoft/vscode-css-languageservice#428 for the corresponding hovercard UI changes