Added function to register and clear external schema in the language service Interface #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
Fixed indentation
Contributor
Author
|
@aeschli Could you please take a look when convenient? |
Collaborator
|
@rahulbanerjee26 I'd rather avoid extra API just for convenience. In the end it's API to maintain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a couple of functions to the Json Language Service Interface
Right now, if a user wants to register or clear schemas, the only way to do it is by using
configure. Sinceconfigureoverwrites previously registered schemas, this would require the user to maintain a list of schemas and update it accordingly and use it along withconfigure.I noticed JSONSchema service has some utility functions that could make the above process easier. Please let me know your thoughts or if I misunderstood something and if there is currently a way to register/clean schemas without having to maintain a list of schemas.