Update npm packages, node version and resolve debug logging

.github/workflows/build-test.yml

@@ -16,7 +16,7 @@ on:
   workflow_dispatch:
 
 env:
-  NODE_VERSION: 16.14.2
+  NODE_VERSION: 18.15.0
   NPM_VERSION: 8.15.1
   PYTHON_VERSION: '3.10'
 

.nvmrc

@@ -1 +1 @@
-v16.14.2
+v18.15.0

CONTRIBUTING.md

@@ -11,7 +11,7 @@
 
 ### Prerequisites
 
-1. [Node.js](https://nodejs.org/) 16.14.2
+1. [Node.js](https://nodejs.org/) v18.15.0
 2. [npm](https://www.npmjs.com/) 8.15.1
 3. [Python](https://www.python.org/) 3.8 or later
 4. Windows, macOS, or Linux

package.json

@@ -127,8 +127,8 @@
         "@typescript-eslint/parser": "^6.2.0",
         "@vscode/dts": "^0.4.0",
         "@vscode/jupyter-extension": "^0.0.7",
-        "@vscode/test-electron": "^2.3.4",
-        "@vscode/test-web": "^0.0.56",
+        "@vscode/test-electron": "^2.4.1",
+        "@vscode/test-web": "^0.0.62",
         "assert": "^2.1.0",
         "chai": "^4.3.8",
         "chai-as-promised": "^7.1.1",

src/common/logging.ts

@@ -37,7 +37,7 @@ export function traceError(..._args: unknown[]): void {
     logMessage('error', ..._args);
 }
 
-export function traceDebug(_message: string, ..._args: unknown[]): void {
+export function traceDebug(..._args: unknown[]): void {
     if (loggingLevel !== 'debug') {
         return;
     }

src/jupyterHubApi.ts

@@ -206,7 +206,9 @@ export async function getUserInfo(
     const headers = { Authorization: `token ${token}` };
     const response = await fetch.send(url, { method: 'GET', headers }, cancellationToken);
     if (response.status === 200) {
-        return response.json();
+        const json = await response.json();
+        traceDebug(`Got user info for user ${baseUrl} = ${JSON.stringify(json)}`);
+        return json;
     }
     throw new Error(await getResponseErrorMessageToThrowOrLog(`Failed to get user info`, response));
 }

src/jupyterIntegration.ts

@@ -183,6 +183,7 @@ export class JupyterServerIntegration implements JupyterServerProvider, JupyterS
         if (!serverInfo) {
             throw new Error('Server not found');
         }
+        traceDebug(`Server Info for ${server.id} is ${JSON.stringify(serverInfo)}`);
         const authInfo = await this.storage.getCredentials(server.id);
         if (!authInfo) {
             throw new Error(`Server ${server.id} not found`);
@@ -250,6 +251,7 @@ export class JupyterServerIntegration implements JupyterServerProvider, JupyterS
 
         // https://github.com/microsoft/vscode-jupyter-hub/issues/53
         const baseUrl = Uri.parse(rawBaseUrl);
+        traceDebug(`Resolved server ${server.id} to ${baseUrl.toString(true)}`);
         const brokenUrl = new this.nodeFetchImpl.Request(baseUrl.toString(true)).url;
         const correctUrl = new this.nodeFetchImpl.Request(rawBaseUrl).url;
         const brokenWsUrl = brokenUrl.replace('http', 'ws');