Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a period in step 2 (Quick start) for good alignment of Readme file. #10587

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Krishnamohan-Yerrabilli
Copy link

@Krishnamohan-Yerrabilli Krishnamohan-Yerrabilli commented Jun 27, 2022

Fixes #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

Added a period to step 2 (Quick start) for better alignment.
@Krishnamohan-Yerrabilli Krishnamohan-Yerrabilli requested a review from a team as a code owner June 27, 2022 13:45
@codecov-commenter
Copy link

Codecov Report

Merging #10587 (6dd7433) into main (5ba3946) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10587   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        472      472           
  Lines      28011    28011           
  Branches    4697     4697           
======================================
- Hits       19961    19946   -15     
- Misses      6182     6191    +9     
- Partials    1868     1874    +6     
Impacted Files Coverage Δ
src/notebooks/outputs/tracebackFormatter.ts 93% <0%> (-7%) ⬇️
...ooks/languages/emptyNotebookCellLanguageService.ts 77% <0%> (-5%) ⬇️
.../kernels/raw/launcher/kernelEnvVarsService.node.ts 68% <0%> (-3%) ⬇️
src/kernels/variables/debuggerVariables.ts 69% <0%> (-3%) ⬇️
...form/common/process/pythonExecutionFactory.node.ts 73% <0%> (-3%) ⬇️
src/standalone/api/kernelApi.ts 72% <0%> (-2%) ⬇️
src/kernels/variables/kernelVariables.ts 56% <0%> (-2%) ⬇️
src/platform/webviews/webviewHost.ts 80% <0%> (-1%) ⬇️
src/kernels/kernel.base.ts 82% <0%> (-1%) ⬇️
src/platform/common/utils/localize.ts 76% <0%> (-1%) ⬇️
... and 4 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants