Skip to content

Revert "Fix spawn calls to use Windows path quoting (#17020)" #17044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

Revert "Fix spawn calls to use Windows path quoting (#17020)" #17044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/platform/common/process/proc.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
import { logProcess } from './logger.node';
import { noop } from '../utils/misc';
import { dispose } from '../utils/lifecycle';
import { fileToCommandArgument } from '../helpers';

export class BufferDecoder implements IBufferDecoder {
public decode(buffers: Buffer[]): string {
Expand Down Expand Up @@ -81,7 +80,7 @@ export class ProcessService implements IProcessService {

public execObservable(file: string, args: string[], options: SpawnOptions = {}): ObservableExecutionResult<string> {
const spawnOptions = this.getDefaultOptions(options);
const proc = spawn(fileToCommandArgument(file), args, spawnOptions);
const proc = spawn(file, args, spawnOptions);
Copy link
Contributor Author

@DonJayamanne DonJayamanne Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't quote file paths in spawn here
As the first argument itself is the file, & second is the arguments.
Only cases where the command is a combination of file and arguments do we need to quote the file.

let procExited = false;
logger.ci(`Exec observable ${file}, ${args.join(' ')}`);
const disposables: IDisposable[] = [];
Expand Down Expand Up @@ -156,7 +155,7 @@ export class ProcessService implements IProcessService {
}
public exec(file: string, args: string[], options: SpawnOptions = {}): Promise<ExecutionResult<string>> {
const spawnOptions = this.getDefaultOptions(options);
const proc = spawn(fileToCommandArgument(file), args, spawnOptions);
const proc = spawn(file, args, spawnOptions);
const deferred = createDeferred<ExecutionResult<string>>();
const disposable: IDisposable = {
dispose: () => {
Expand Down
Loading