Pending CI status precedence over review required (#4277)

* Use warning + circle-filled for review required Fixes #4259 * Pending CI status precedence over review required Fixes #4269
microsoft · Nov 30, 2022 · 0b2038d · 0b2038d
1 parent bd312a3
commit 0b2038d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/view/prStatusDecorationProvider.ts b/src/view/prStatusDecorationProvider.ts
@@ -63,18 +63,18 @@ export class PRStatusDecorationProvider implements vscode.FileDecorationProvider
 				badge: new vscode.ThemeIcon('request-changes', new vscode.ThemeColor('list.errorForeground')),
 				tooltip: 'Changes requested'
 			};
-		} else if (status & UnsatisfiedChecks.ReviewRequired) {
-			return {
-				propagate: false,
-				badge: new vscode.ThemeIcon('circle'),
-				tooltip: 'Review required'
-			};
 		} else if (status & UnsatisfiedChecks.CIPending) {
 			return {
 				propagate: false,
 				badge: new vscode.ThemeIcon('sync', new vscode.ThemeColor('list.warningForeground')),
 				tooltip: 'Checks pending'
 			};
+		} else if (status & UnsatisfiedChecks.ReviewRequired) {
+			return {
+				propagate: false,
+				badge: new vscode.ThemeIcon('circle-filled', new vscode.ThemeColor('list.warningForeground')),
+				tooltip: 'Review required'
+			};
 		} else if (status === UnsatisfiedChecks.None) {
 			return {
 				propagate: false,