Skip to content

Avoid throwing and handling exception is avoidable #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 1 commit into from
Nov 18, 2024
Merged

Avoid throwing and handling exception is avoidable #6484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/common/uri.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export interface PRUriParams {
}

export function fromPRUri(uri: vscode.Uri): PRUriParams | undefined {
if (uri.query === '') {
return undefined;
}
try {
return JSON.parse(uri.query) as PRUriParams;
} catch (e) { }
Expand All @@ -51,6 +54,9 @@ export interface PRNodeUriParams {
}

export function fromPRNodeUri(uri: vscode.Uri): PRNodeUriParams | undefined {
if (uri.query === '') {
return undefined;
}
try {
return JSON.parse(uri.query) as PRNodeUriParams;
} catch (e) { }
Expand All @@ -63,6 +69,9 @@ export interface GitHubUriParams {
isEmpty?: boolean;
}
export function fromGitHubURI(uri: vscode.Uri): GitHubUriParams | undefined {
if (uri.query === '') {
return undefined;
}
try {
return JSON.parse(uri.query) as GitHubUriParams;
} catch (e) { }
Expand Down Expand Up @@ -338,8 +347,11 @@ export function toResourceUri(uri: vscode.Uri, prNumber: number, fileName: strin
}

export function fromFileChangeNodeUri(uri: vscode.Uri): FileChangeNodeUriParams | undefined {
if (uri.query === '') {
return undefined;
}
try {
return uri.query ? JSON.parse(uri.query) as FileChangeNodeUriParams : undefined;
return JSON.parse(uri.query) as FileChangeNodeUriParams;
} catch (e) { }
}

Expand Down